Mark Wu has uploaded a new change for review.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
tests: Fix parted_utils_tests break on fedora 18
parted 3.1 improves its support for loopback devices. The 'model' string returned by libparted is updated to 'Loopback device'. For more information, please see: http://anonscm.debian.org/gitweb/?p=parted/parted.git;a=commit;h=3e35b6
Because another bug of parted.version() on rhel6 (https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=700383), we can't use parted.version() to differentiate the parted version. We could restort to rpm db, but loop device is only used in test code, so it should be safe to ignore the test of model string.
Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M tests/parted_utils_tests.py 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/11137/1
diff --git a/tests/parted_utils_tests.py b/tests/parted_utils_tests.py index 808d748..ce413d7 100644 --- a/tests/parted_utils_tests.py +++ b/tests/parted_utils_tests.py @@ -79,7 +79,6 @@
def _blank_dev_test(self): info = putils.getDevicePartedInfo(self.devPath) - self.assertFalse(info['model']) self.assertTrue(info['sectorSize'] >= 0) self.assertFalse(info['type']) self.assertFalse(info['partitions']) @@ -99,7 +98,6 @@ time.sleep(1) # wait for syncing
info = putils.getDevicePartedInfo(self.devPath) - self.assertFalse(info['model']) self.assertTrue(info['sectorSize'] >= 0) self.assertEquals(info['type'], 'gpt') self.assertTrue(info['freeSpaceRegions'][0][3] >= FREE_SIZE)
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/803/ (1/2)
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/768/ (2/2)
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/768/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/803/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1: Verified
Verified on F17 and F18. For rhel6, it should pass the too because we just remove the test of model string.
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
Patch Set 1: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix parted_utils_tests break on fedora 18 ......................................................................
tests: Fix parted_utils_tests break on fedora 18
parted 3.1 improves its support for loopback devices. The 'model' string returned by libparted is updated to 'Loopback device'. For more information, please see: http://anonscm.debian.org/gitweb/?p=parted/parted.git;a=commit;h=3e35b6
Because another bug of parted.version() on rhel6 (https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=700383), we can't use parted.version() to differentiate the parted version. We could restort to rpm db, but loop device is only used in test code, so it should be safe to ignore the test of model string.
Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M tests/parted_utils_tests.py 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: Mark Wu: Verified Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/11137 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org