From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/75134/4/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
PS4, Line 67: display_ip = '0'
_getNetworkIp takes care of that.
yes, this patch could have
been simplified to
if display_network:
net_api.create_libvirt_network(display_network, self.conf['vmId'])
display_ip = _getNetworkIp(display_network)
but _getNetworkIp() itself should be simplified as well. It should not refer to the
libvirt network that was generated here; it should use a specialized net_api entry for
this mapping.
--
To view, visit
https://gerrit.ovirt.org/75134
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes