Hello Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: Added register-vdc command line tool. ......................................................................
Added register-vdc command line tool.
This tool accepts VDC Host and register current node to the host.
Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm.spec.in M vdsm_reg/Makefile.am A vdsm_reg/register-vdc.py 3 files changed, 149 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/3113/1 -- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-vdc command line tool. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I don't understand the motivation for this script - it seems to edit vdsm-reg.conf, and restart the vdsm-reg service. The TUI implemented in vdsm_reg/engine.py should have done something similar. Could you explain?
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added register-vdc command line tool. ......................................................................
Patch Set 1:
This is generic cli tool to setup/initiate vdsm-reg. This helps to initiate registration of non-ovirt-node eg. Gluster appliance.
I see engine.py doesn't work in non-ovirt-node instances and its very much tight to ovirt node.
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-vdc command line tool. ......................................................................
Patch Set 1:
vdsm-reg *is* tightly coupled with ovirt-node. I am not aware of anything where this is useful outside of that context. Do you?
Please note that VDC is a very-very-old name for ovirt-engine. It can remain inside config files, but I suppose not in cmdline name.
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added register-vdc command line tool. ......................................................................
Patch Set 1:
We want gluster appliance registers itself to given ovirt engine. This is one of use case outside of ovirt node.
I will do VDC name change.
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/register-to-engine.py Line 56: # %s rhevm-server suppose to be oVirt Engine instead of rhevm
Line 57: # %s -p 8443 rhevm-server suppose to be oVirt Engine instead of rhevm
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File vdsm_reg/register-to-engine.py Line 56: # %s rhevm-server Done
Line 57: # %s -p 8443 rhevm-server Done
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm_reg/register-to-engine.py Line 145: sys.exit(SUCCESS) Hello Bala.FA,
I am not sure if we should use sys.exit(SUCCESS) without verify if deployUtil.setService returns success or not. Sorry, just noticed that one right now re-reading the code.
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm_reg/register-to-engine.py Line 145: sys.exit(SUCCESS) Done
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 5: (3 inline comments)
.................................................... File vdsm_reg/register-to-engine.py Line 59: """) % (name, name, name) How about:
"Usage: %(name)s" % {'name': name}
Line 93: for o,v in opts: Missing space after the comma.
Line 97: elif o in ("-p", "--port"): How did the space from the comma end up here? ;)
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 5: (3 inline comments)
.................................................... File vdsm_reg/register-to-engine.py Line 59: """) % (name, name, name) much better. I will fix it. Thanks.
Line 93: for o,v in opts: Done
Line 97: elif o in ("-p", "--port"): I will fix that :)
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 6: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 6: I would prefer that you didn't submit this
register-to-engine.py file does not have execute permission when it's installed using vdsm-reg rpm
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Xu He Jie has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_reg/Makefile.am Line 35: register-to-engine.py This can be clean by 'make clean'.
.................................................... File vdsm_reg/register-to-engine.py Line 139: if not deployUtil.setVdsConf("vdc_host_name=%s" % newVdcHostName, Why we didn't use 'ConfigParser' to set config directly? deployUtil.py used by engine to execute remotely
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: (1 inline comment)
.................................................... File vdsm_reg/register-to-engine.py Line 139: if not deployUtil.setVdsConf("vdc_host_name=%s" % newVdcHostName, there were several (wrong?) reasons to write our own function for this (maintaining order and comments I believe). I'd be happy to replace deployUtil.setVdsConf, but that's outside of the scope of this patch.
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Timothy Asir has posted comments on this change.
Change subject: Added register-to-engine command line tool. ......................................................................
Patch Set 7: Verified
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added register-to-engine command line tool. ......................................................................
Added register-to-engine command line tool.
This tool accepts oVirt Engine name and register current node to the engine.
Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Signed-off-by: Bala.FA barumuga@redhat.com --- M vdsm.spec.in M vdsm_reg/Makefile.am A vdsm_reg/register-to-engine.py 3 files changed, 157 insertions(+), 1 deletion(-)
Approvals: Timothy Asir: Verified Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
Objections: Xu He Jie: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/3113 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org