From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: migrated ...AddBondWithManyVlans to the new functional tests
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/69503/2/tests/network/func_net_with_bond_tes...
File tests/network/func_net_with_bond_test.py:
PS2, Line 99: tag
this is 0-based, two lines above is 1-based. too confusing.
PS2, Line 99: vlan_name
in this very line, a list of these is called network_names. a singular of it should be
network_name, not vlan_name.
Actually, I think you can do without the network_names list. You don't need another
place to store the keys of the network dict.
--
To view, visit
https://gerrit.ovirt.org/69503
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36d2224078eb128ffdc14c033ee11b649fe6628b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes