Shu Ming has uploaded a new change for review.
Change subject: Use setattr instead of __dict__ ......................................................................
Use setattr instead of __dict__
It is bad to access the __dict__ directly
Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Signed-off-by: Shu Ming shuming@linux.vnet.ibm.com --- M vdsm/storage/dispatcher.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/6870/1 -- To view, visit http://gerrit.ovirt.org/6870 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Use setattr instead of __dict__ ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6870 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Use setattr instead of __dict__ ......................................................................
Patch Set 1: Looks good to me, approved
Indeed, fixing bad style.
-- To view, visit http://gerrit.ovirt.org/6870 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Use setattr instead of __dict__ ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/6870 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Use setattr instead of __dict__ ......................................................................
Use setattr instead of __dict__
It is bad to access the __dict__ directly
Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Signed-off-by: Shu Ming shuming@linux.vnet.ibm.com --- M vdsm/storage/dispatcher.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Shu Ming: Verified Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6870 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I685057743eec8ab76a274a7546199f7115903ba7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org