Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: add version/release to dsaversion ......................................................................
vdsm.spec: add version/release to dsaversion
Adds the current software_revision and software_version to dsaversion.
Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/4284/1 -- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: add version/release to dsaversion ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: add version/release to dsaversion ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm.spec.in Line 273: make clearly, the Right Thing is to fix this by having vdsm/dsaversion.py.in.
If you are anxious to have SOMETHING in, as a stop-gap measure, please add a TODO comment explaining how it SHOULD be done.
-- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: dsaversion: renamed to dsaversion.in ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: dsaversion: renamed to dsaversion.in ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm.spec.in Line 273: make Done
-- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b4a63a974bfc301f3294603d8fe91f534b74dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
vdsm-patches@lists.fedorahosted.org