Nir Soffer has uploaded a new change for review.
Change subject: build: Remove build requires needed for the tests ......................................................................
build: Remove build requires needed for the tests
We are not running the tests during the build, so we don't need to pull these packages. These packages are installed in the CI using automation/check-patch.packages. Developers should also use the same file for setting up a development environment.
Change-Id: I3c385b0abeb2657a26215ce5b96976cc290734bb Signed-off-by: Nir Soffer nsoffer@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 55 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/65500/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 9252530..e4806fe 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -57,54 +57,10 @@
%{!?_licensedir:%global license %%doc}
-BuildRequires: cyrus-sasl-lib BuildRequires: python BuildRequires: python2-devel -BuildRequires: python-mock -BuildRequires: python-netaddr -BuildRequires: python-six >= 1.9.0 BuildRequires: rpm-build - -# BuildRequires needed by the tests during the build -BuildRequires: dosfstools -BuildRequires: genisoimage -BuildRequires: libnl3 -BuildRequires: libselinux-python -BuildRequires: libvirt-python -BuildRequires: m2crypto -BuildRequires: mom >= 0.5.5 -BuildRequires: openssl -BuildRequires: policycoreutils-python -BuildRequires: psmisc -BuildRequires: PyYAML -BuildRequires: python-cpopen >= 1.4-1 -BuildRequires: python-inotify -BuildRequires: python-ioprocess >= 0.16.1-1 -BuildRequires: python-pthreading -BuildRequires: qemu-img -BuildRequires: rpm-python -%if 0%{?with_gluster_mgmt} -BuildRequires: python-blivet -%endif -BuildRequires: sanlock-python - -%if 0%{?with_openvswitch} -BuildRequires: openvswitch >= 2.0.0 -%endif - -%if 0%{?with_python3} -%if 0%{?rhel} -BuildRequires: python34-nose -BuildRequires: python34-six -%else # fedora -BuildRequires: python3-nose -BuildRequires: python3-six -BuildRequires: python3-netaddr -BuildRequires: python3-yaml -BuildRequires: libselinux-python3 -BuildRequires: libvirt-python3 -%endif # rhel -%endif # support python3 +BuildRequires: systemd-units
# Autotools BuildRequires %if 0%{?enable_autotools} @@ -114,16 +70,6 @@ BuildRequires: libtool %endif
-BuildRequires: systemd-units - -%if 0%{?rhel} -BuildRequires: python-decorator -%endif # rhel - -%if 0%{?fedora} -BuildRequires: python2-decorator -BuildRequires: python3-decorator -%endif
# Numactl is not available on s390[x] and ARM %ifnarch s390 s390x %{arm}
gerrit-hooks has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1:
* Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
Nir Soffer has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1: Verified+1
Verified locally on Fedora 24.
Irit Goihman has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1: Code-Review+1
Eyal Edri has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1:
You're assuming you'll always have .packages file. What will happen if you'll run vdsm build outside ovirt CI?
Won't it be better to enable a Boolean like 'enable_tests' same as we had for gluster, so a user can choose if to use it when building?
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1:
Eyal, we no longer want to run tests during RPM build time.
In our devel docs http://www.ovirt.org/develop/developer-guide/vdsm/developers/ we ask to install devel packages with
yum install `cat automation/check-patch.packages.el7`
so yes, we intentionally depend on the existence of .packages
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: build: Remove build requires needed for the tests ......................................................................
Patch Set 1: Code-Review+2
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Remove build requires needed for the tests ......................................................................
build: Remove build requires needed for the tests
We are not running the tests during the build, so we don't need to pull these packages. These packages are installed in the CI using automation/check-patch.packages. Developers should also use the same file for setting up a development environment.
Change-Id: I3c385b0abeb2657a26215ce5b96976cc290734bb Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/65500 Continuous-Integration: Jenkins CI Reviewed-by: Irit Goihman igoihman@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 55 deletions(-)
Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
vdsm-patches@lists.fedorahosted.org