Federico Simoncelli has uploaded a new change for review.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Remove the traceback from the getVSize warning
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f --- M vdsm/storage/blockVolume.py 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/5294/1 -- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 10: useless and confusing (for an example see BZ#829645). sorry, I do not understand why this is the case.
could you spend few comment lines to give more details? think of the git-blamer of the future, trying to understand the non-standard piece of code you are adding.
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/blockVolume.py Line 96: if not (type(e) == IOError and e.errno == os.errno.ENOENT): python purists would say: use isinstance().
(I am not a purist. I just know we have a couple of those around)
Line 101: return int(lvm.getLV(sdobj.sdUUID, volUUID).size) / int(bs) is bs expected to ever be non-int? is this change of "int" placement included just to test my level of awareness? it does not seem related to the commit message.
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 8: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 8: (1 inline comment)
.................................................... Commit Message Line 10: enabled was using the wrong exception type. I think you missed a comma here (...is not enabled was using...)
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 9: (1 inline comment)
.................................................... Commit Message Line 10: enabled was using the wrong exception type. I think you missed a comma here or and (...is not enabled was using...)
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 9: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Patch Set 10: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove the traceback from the getVSize warning ......................................................................
Remove the traceback from the getVSize warning
The check used in getVSize to skip the log warnings (when the LV is not enabled), was using the wrong exception type.
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f --- M vdsm/storage/blockVolume.py 1 file changed, 7 insertions(+), 9 deletions(-)
Approvals: Federico Simoncelli: Verified; Looks good to me, approved Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/5294 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f12065224636e65b8ccabcbdae83b41290229f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org