Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
vdsmd.init: remove validation to reload config
packaged=`/bin/rpm -ql libvirt | /bin/grep libvirtd.upstart | /usr/bin/tail -1` returns: "/usr/share/doc/libvirt.0.X.Y/libvirtd.upstart"
However, in oVirt Node/RHEV-H we don't have /usr/share/doc dir.
So, when executing:
/bin/cp -p "$packaged" "$target" || return 1
The above code will always execute 'return 1' since the source $packaged doesn't exist, making the function exit before start libvirt daemon via upstart.
Start operation is not often required, let's just reload configuration and start libvirt daemon.
Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm/vdsmd.init.in 1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/4479/1 -- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Does this solve a real problem? I think that in oVirt node, there is never a new version of libvirt that is introduced, so we never need to reload-configuration.
`initctl reload-configuratoin` is not something that normal sysV services do, so it carries a surprise factor I would like to avoid.
Maybe a clearer code would be to avoid this code section of ovirt node (assuming there is no functional problem fixed by this patch)
Sorry I did not see this issue in a private correspondece we had earlier.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1:
Does this solve a real problem?
Yes, we do not validate a non existing path/file. /usr/share/doc/libvirt.0.X.Y/libvirtd.upstart
I think that in oVirt node, there is never a new version of libvirt that is introduced, so we never need to reload-configuration. `initctl reload-configuratoin` is not something that normal sysV services do, so it carries a surprise factor I would like to avoid.
Well, users can modify the file /etc/init/libvirt.conf and next time they execute /etc/init.d/vdsmd start it will load the new configuration automatically. If you think we don't need to worry about it, I am ok to remove the the reload-configuration stuff too.
Please let me know your opinion.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1:
I still do not quite understand the problem you are trying to solve. I see two:
1. upstart game is done on ovirt-node, were it is not needed 2. /etc/init/libvirt.conf is overwritten by a too-aggressive vdsm 3. weird behavior if no libvirt.conf is found
(1) should be solved by checking if we're running on ovirt-node. (2) is a price I'm willing to pay in order to keep libvirtd up after a crash (3) should be fixed by [[ -z "$packaged" ]] or something like that.
removal of the upstart dance is not something I'm willing to drop for these reasons.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/123/
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/123/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has abandoned this change.
Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: Abandoned
http://gerrit.ovirt.org/#/c/7375/ replaces this patch.
-- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org