Ayal Baron has posted comments on this change.
Change subject: Add the validateImage command to the SPM
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 2121:
Line 2122: self.validateSdUUID(sdUUID)
Line 2123: misc.validateUUID(imgUUID, 'imgUUID')
Line 2124:
Line 2125: vars.task.getSharedLock(STORAGE, sdUUID)
considering the issue with upgrade taking the lock for a long time, is this lock correct
here?
Line 2126: self._spmSchedule(spUUID, "validateImage",
Line 2127: pool.validateImage, sdUUID, imgUUID)
Line 2128:
Line 2129: @public
....................................................
File vdsm/storage/image.py
Line 761: chain = self.prepare(sdUUID, imgUUID)
Line 762:
Line 763: try:
Line 764: for vol in chain:
Line 765: vol.validateMetadata()
because each volume may potentially have different metadata?
Line 766: finally:
Line 767: self.teardown(sdUUID, imgUUID)
Line 768:
Line 769: def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID,
dstVolUUID,
--
To view, visit
http://gerrit.ovirt.org/3491
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I095362e7d1eb91045569bd9526a102392e7adbe8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server