Federico Simoncelli has posted comments on this change.
Change subject: bz#831938 raise exception when error occurs in connectStorageServer
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 1937: self.log.error("Could not connect to storageServer",
exc_info=True)
Line 1938: raise
Line 1939: # Connecting new device may change the visible storage domain list
Line 1940: # so invalidate caches
Line 1941: sdCache.invalidateStorage()
connectStorageServer receives a list of connections and returns a list of results (e.g.
which connections succeeded and which ones failed). At the present time we cannot modify
that for backward compatibility. More importantly in the change you're suggesting
there's no feedback on what connections succeeded before failing (raise).
Line 1942:
Line 1943: @deprecated
Line 1944: def _connectStorageOverIser(self, conDef, conObj, conTypeId):
Line 1945: """
--
To view, visit
http://gerrit.ovirt.org/6137
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c363f41d08669eec022797eb1eb440fe193f9c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes