Xu He Jie has uploaded a new change for review.
Change subject: fix pep8 for vdsm/sos/vdsmd.py.in ......................................................................
fix pep8 for vdsm/sos/vdsmd.py.in
Change-Id: I3fa7ce9a621ad825f7942e19c20beb3498280975 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M Makefile.am M vdsm/sos/vdsmd.py.in 2 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/4582/1 -- To view, visit http://gerrit.ovirt.org/4582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I3fa7ce9a621ad825f7942e19c20beb3498280975 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: fix pep8 for vdsm/sos/vdsmd.py.in ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3fa7ce9a621ad825f7942e19c20beb3498280975 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix pep8 for vdsm/sos/vdsmd.py.in ......................................................................
Patch Set 1: (1 inline comment)
Please refer to the inline comments in line 34 of vdsmd.py.in.
.................................................... File vdsm/sos/vdsmd.py.in Line 34: How about:
optionList = [ ("logsize", 'max size (MiB) to collect per log file', '', False)]
or
optionList = [("logsize", 'max size (MiB) to collect per log file', '', False)]
-- To view, visit http://gerrit.ovirt.org/4582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3fa7ce9a621ad825f7942e19c20beb3498280975 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Xu He Jie has abandoned this change.
Change subject: fix pep8 for vdsm/sos/vdsmd.py.in ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/4582 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I3fa7ce9a621ad825f7942e19c20beb3498280975 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org