Laszlo Hornyak has uploaded a new change for review.
Change subject: CpuPinning for vdsClient ......................................................................
CpuPinning for vdsClient
Adds support for CpuPinning arguments in vdsClient. example: cpuPinning="{{'vcpu': '0', 'cpuset': '0'}]}"
Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Signed-off-by: Laszlo Hornyak lhornyak@redhat.com --- M vdsm_cli/vdsClient.py 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/4905/1 -- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm_cli/vdsClient.py Line 158: cpuPinning = [] I'd expect a dictionary, this is surprising.
Line 163: if param == 'devices': bad indentation. please run
make check-local
before submitting code - pyflakes should have caught this.
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vdsm_cli/vdsClient.py Line 158: cpuPinning = [] Intended to be a list of dictionaries and when creating the data through engine it works nicely
cpuPinning = [{'cpuset': '2', 'vcpu': '0'}, {'cpuset': '1', 'vcpu': '1'}]
However, when using the command line, the client creates the wrong data structure:
cpuPinning = [[{'vcpu': '0', 'cpuset': '4'}, '']]
Looks like a list of list of dictionaries, plus an empty string :(
Line 163: if param == 'devices': Done
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 3: Verified
- fixed spacing - also fixed call to _parseNestedSpec (added handling multiple return values)
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
minor comments
.................................................... Commit Message Line 11: cpuPinning="[{vcpu:0,cpuset:0#4}]" I think the comment is not up-to-date.
better mention this in the run-time help text (look for 'o devices' for example)
.................................................... File vdsm_cli/vdsClient.py Line 158: cpuPinning = [] I find this confusing - better initialize this with an empty dict.
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Laszlo Hornyak has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient ......................................................................
Patch Set 6: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: CpuPinning for vdsClient ......................................................................
CpuPinning for vdsClient
Adds support for CpuPinning arguments in vdsClient. example: cpuPinning="{0:'1'}"
Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Signed-off-by: Laszlo Hornyak lhornyak@redhat.com --- M vdsm_cli/vdsClient.py 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: Laszlo Hornyak: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4905 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com
vdsm-patches@lists.fedorahosted.org