Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP 8: fix ignored errors E12{6,7,8}
......................................................................
Patch Set 1: Verified
Pass autobuild.sh. gitpydiff finds no changes on all the files except constants.py.in and
blockVolume.py . The changes are about modifying the string literals. They are acceptable
because the original string literals are wrong, the modified ones are right.
Detailed report:
For vdsm/constants.py.in:
1 difference(s)
first file: vdsm/constants.py.in
second file: /tmp/pydiff/vdsm/constants.py.in
((159,
'\n\ndefaults {\n polling_interval 5\n getuid_callout
"@SCSI_ID_PATH@ --whitelisted --replace-whitespace --device=/dev/%n"\n
no_path_retry fail\n user_friendly_names no\n flush_on_last_del
yes\n fast_io_fail_tmo 5\n dev_loss_tmo 30\n max_fds
4096\n}\n\ndevices {\ndevice {\n vendor "HITACHI"\n
product "DF.*"\n getuid_callout "@SCSI_ID_PATH@
--whitelisted --replace-whitespace --device=/dev/%n"\n}\ndevice {\n vendor
"COMPELNT"\n product "Compellent Vol"\n
no_path_retry fail\n}\n}'),
(159,
'\n\ndefaults {\n polling_interval 5\n getuid_callout
"@SCSI_ID_PATH@ --whitelisted --replace-whitespace
--device=/dev/%n"\n no_path_retry fail\n user_friendly_names no\n
flush_on_last_del yes\n fast_io_fail_tmo 5\n dev_loss_tmo
30\n max_fds 4096\n}\n\ndevices {\ndevice {\n vendor
"HITACHI"\n product "DF.*"\n getuid_callout
"@SCSI_ID_PATH@ --whitelisted --replace-whitespace
--device=/dev/%n"\n}\ndevice {\n vendor "COMPELNT"\n
product "Compellent Vol"\n no_path_retry
fail\n}\n}'))
For vdsm/storage/blockVolume.py:
1 difference(s)
first file: vdsm/storage/blockVolume.py
second file: /tmp/pydiff/vdsm/storage/blockVolume.py
((553, 'missing offset tag on volume%s/%s'),
(556, 'missing offset tag on volume %s/%s'))
--
To view, visit
http://gerrit.ovirt.org/10674
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia857d54f0634f71af15b5198a613f9113f85a7a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server