From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Handle VDSM services restart on upgrade to posttrans ......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/77785/1//COMMIT_MSG Commit Message:
PS1, Line 19: twice
Can we hack it somehow not to have it?
not much. if we avoid running the new script we won't have edi's logic that restart the network-vdsm service - which was the initial reason for updating this area of the code.
in the other hand, we can change old versions which already have this code in their postun.
I think its alright to run it twice only after upgrade - vdsmd restart should not cause libvirtd restart, and the time between the restarts is quite short. I don't see risks.. same if we restarted libvirt and we'll run it twice in short time - it won't really matter (guess between the postun run to the posttrans not much is passed)
vdsm-patches@lists.fedorahosted.org