Federico Simoncelli has uploaded a new change for review.
Change subject: Bump libvirt required version for RHEL6 ......................................................................
Bump libvirt required version for RHEL6
The version bump is required to avoid the libvirt error "Shareable leases are not supported" when starting a VM (rhbz838819).
Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/7537/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index ce73f6e..0d1b195 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -54,7 +54,7 @@ # Update the qemu-kvm requires when block_stream will be included Requires: qemu-kvm >= 2:0.12.1.2-2.227 Requires: qemu-img >= 2:0.12.1.2-2.227 -Requires: libvirt >= 0.9.10-20 +Requires: libvirt >= 0.9.10-21.el6_3.4 Requires: libvirt-python, libvirt-lock-sanlock Requires: iscsi-initiator-utils >= 6.2.0.872-15 Requires: device-mapper-multipath >= 0.4.9-52
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Bump libvirt required version for RHEL6 ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 3: AuthorDate: 2012-08-28 09:25:19 -0400 Line 4: Commit: Federico Simoncelli fsimonce@redhat.com Line 5: CommitDate: 2012-08-28 09:38:39 -0400 Line 6: Line 7: Bump libvirt required version for RHEL6 Let's avoid the RH trademark Line 8: Line 9: The version bump is required to avoid the libvirt error "Shareable Line 10: leases are not supported" when starting a VM (rhbz838819). Line 11:
Line 6: Line 7: Bump libvirt required version for RHEL6 Line 8: Line 9: The version bump is required to avoid the libvirt error "Shareable Line 10: leases are not supported" when starting a VM (rhbz838819). let's conform to
Bug-Id: url-of-bug Line 11: Line 12: Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bump libvirt required version for RHEL6 ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/723/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has posted comments on this change.
Change subject: Bump libvirt required version for RHEL6 ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 6: Line 7: Bump libvirt required version for RHEL6 Line 8: Line 9: The version bump is required to avoid the libvirt error "Shareable Line 10: leases are not supported" when starting a VM (rhbz838819). Ah so we went for the inconsistent Bug-Id with an url (instead of Bug-Url). Anyway that is not a vdsm bug and this patch doesn't fix rhbz838819. Line 11: Line 12: Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Bump libvirt required version for EL6 ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bump libvirt required version for EL6 ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/725/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Bump libvirt required version for EL6 ......................................................................
Patch Set 2: Verified
safe enough
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Bump libvirt required version for EL6 ......................................................................
Bump libvirt required version for EL6
The version bump is required to avoid the libvirt error "Shareable leases are not supported" when starting a VM (rhbz838819).
Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7537 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie6d971a6ec52bda97d0f1245e1fc72387f81a9d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org