Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
bootstrap: send complete bootstrap from engine
CURRENT BEHAVIOR
vds_installer.py is part of ovirt-engine, upon bootstrap, the script is sent to the node using ssh.
Then vds_installer.py pulls vdsm-bootstrap files using HTTP from engine.
NEW BEHAVIOR
vds_installer.py was moved into the vdsm-bootstrap and renamed to setup.
vdsm-bootstrap repository was updated to create a single tarball with suitable file names and attributes.
ovirt-engine copies the tarball to node into temporary directory, extracts it and run setup script.
No HTTP communication is needed.
No conflict with existing files.
Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M .gitignore M vds_bootstrap/Makefile.am A vds_bootstrap/setup M vdsm.spec.in M vdsm_reg/Makefile.am M vdsm_reg/deployUtil.py.in 6 files changed, 362 insertions(+), 26 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/6962/1 -- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
This is a dependency for [1] at engine side.
[1] http://gerrit.ovirt.org/#/c/6963/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Please return the running dir to be as it used to. It should run from wherever it's used. This has implications both on ovirt node and standard hosts.
.................................................... File vdsm_reg/deployUtil.py.in Line 59: _WORK_DIR = "/tmp" # hardcoded as server use it as-is no... this should work from wherever it runs.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
Please return the running dir to be as it used to. It should run from wherever it's used. This has implications both on ovirt node and standard hosts.
This is incorrect, as server copy this into hardcoded /tmp no matter what destination os think temp location is.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
you got a patch which avoids tmp folder. Do not hard code it.
The current code works from wherever it's executed. And this is a better approach.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
It is not better if server hardcode to /tmp and the other side guess via system dependent configuration.
If this is hardcoded at one side it should be hardcoded at the other, or they lose sync.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
Proof:
$ TMPDIR=/var/tmp python2 -c "import tempfile print tempfile.gettempdir()"
/var/tmp
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
What happens if there's no /tmp? Server will fail. Right? Now let's say you wish to help the users. How will you do it without rebuilding everything?
Having server side use a value which comes from the DB, and the scripts looking for the defined TMP folder will help you without the need to compile, build, etc.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
Doron,
I really don't understand.
master::VdsInstaller.java:
private static final String _remoteDirectory = "/tmp";
CONSTANT, not configurable.
No way it is working if TMPDIR is configure at node side.
I am not discussing theory, I am discussing current implementation. I promise that if I rewrite this I will explore the possibilities of different standards and FHS.
For now, the best solution is to hardcode it on bootstrap side to sync with engine.
FHS[1] states that /tmp is mandatory, so no issue here for now.
""" 3.17. /tmp : Temporary files 3.17.1. Purpose The /tmp directory must be made available for programs that require temporary files. Programs must not assume that any files or directories in /tmp are preserved between invocations of the program. """
[1] http://www.pathname.com/fhs/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
The current /tmp used in the Java must be replaced, and you got the patch for it. Even if you do not use it now, you still shouldn't be forcing other components to use only that.
As for /tmp in the host, it may be mounted somewhere else, with permissions / selinux restrictions, including tmpfs with size limitations. So for all these cases, we made sure /tmp will work, but going forward, there's no reason to keep hard-coding it.
The above are all non-theoretical as well. All are cases I faced in the past, and bz's opened to fix it.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 1:
Again,
Not sure I follow, this is far from this patch discussion.
If you want alternate location with configuration it can be added in another patch.
This patch keeps current configuration sane, while making the necessary fixes that were on the table.
If we are to put the outputs in different location we should bass this location to the bootstrap script, and make sure we clean after ourselves.
While /tmp is self cleaned and accessible for anyone, see FHS spec.
I don't buy the tmpfs nor selinux arguments:
1. selinux that will not allow user to access /tmp violates the FHS spec.
2. tmpfs should be large enough to contain 500K, as it should be used by sane system, had we used large data, I would have agreed to use /var/tmp instead, but these are the only locations to put such craft.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 2:
For backward compatibility as we cannot enforce engine->vdsm-bootstrap package relationship easily, we keep the bootstrap files at /usr/share/vdsm-bootstrap.
Also added interface version to tarball name, so we can support several interfaces (engines).
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 2:
Just found that we retrieve ssh public key from engine via HTTP in none node mode as well!
Need more time to figure out how to solve this properly.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3:
Transfer the ssh public key of engine using ssh, plus minor cleanups.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/263/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/263/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is humm I remember a case where a user reported no /tmp and his system used another directory as temporary. Will we ignore such cases?
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3: (1 inline comment)
if you would like to add your name to AUTHORS as well..
.................................................... File vds_bootstrap/setup-2 Line 4: # Use is subject to license terms. time to update the copyright.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 3: (2 inline comments)
Thanks for review.
I will add my self to the AUTHORS once I rewrite the whole bootstrap process... :)
.................................................... File vds_bootstrap/setup-2 Line 4: # Use is subject to license terms. OK. I will do this in a different patch.
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is As I wrote, this clearly violates FHS spec. The implication of missing /tmp is far greater than for RHEV, many application will not work.
Current implementation also reply on /tmp so nothing really changed.
I suggest to accept that as-is and if a requirement to use alternate location output files location is to be handled to do this in different patch.
Please keep in mind that in any case the engine uses SINGLE GLOBAL configuration, so if you have a single node which does not comply it forces to change the behaviour of all nodes.
The only real issue that can exist is /tmp mounted as noexec. In this case the output files can still go into /tmp and configure the server to extract the tarball at $HOME of root, this is supported by this patch.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/274/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4:
copyright modified.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/274/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(6 inline comments)
partial review, good night.
.................................................... Commit Message Line 27: tarball name has interface version so several versions may be provided why a tarball instead of a plain rpm? why do we need the additional layer of encapsulation? why bootstrap-1 and bootstrap-2 are shipped within the same rpm?
.................................................... File vds_bootstrap/Makefile.am Line 31: # old servers to use upgraded package server -> engine. right?
.................................................... File vds_bootstrap/vds_bootstrap_complete.py Line 73: if o == "-v": maybe it's time to use longopts? -v and -V are a bit confusing due to they inrelatedness.
.................................................... File vds_bootstrap/vds_bootstrap.py Line 62: filename='/tmp/vdsm-bootstrap-phase1.%s.log' % (strftime("%Y%m%d%H%M%S")), please keep new code in shorter lines.
outer parens in
(strftime("%Y%m%d%H%M%S"))
are meaningless
Line 741: global bootstrap_interface_version you do not need to declare this as global if you do not attempt to change it.
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is why are you reverting the good of directory generalization?
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 4: (6 inline comments)
.................................................... Commit Message Line 27: tarball name has interface version so several versions may be provided I think we discussed this.
As we have vdsm-bootstrap package that should be installed with several engines we need to support multiple interfaces.
I believe a better solution is to move the bootstrap out of the vdsm project, into the engine or as standalone. So that engine and bootstrap version can be independent of the vdsm version and repository.
.................................................... File vds_bootstrap/Makefile.am Line 31: # old servers to use upgraded package Right.
.................................................... File vds_bootstrap/vds_bootstrap_complete.py Line 73: if o == "-v": right. Or better key=value to allow more flexibility.
I will do this once I rewrite not now.
.................................................... File vds_bootstrap/vds_bootstrap.py Line 62: filename='/tmp/vdsm-bootstrap-phase1.%s.log' % (strftime("%Y%m%d%H%M%S")), Done
Line 741: global bootstrap_interface_version Done
.................................................... File vdsm_reg/deployUtil.py.in Line 60: _WORK_DIR = "/tmp" # hardcoded as server use it as-is Because the engine hardcoded to get output from /tmp.
We went over and over this issue, this is how it runs now, it was wrong to have this statement at bootstrap side as long as server hardcoded to use /tmp.
For future we can discuss how to sync directories between engine and vdsm.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/340/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 5:
Trivial fixes per dan comments.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/340/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 5: I would prefer that you didn't submit this
I recall that we talked about the tarball in a noisy corridor, but I cannot say that I liked the extra layer then nor now. imo a subdir in an rpm is better.
Would you agree to separate this patch into functionally distinct changes? log fixes could have been taken immediately. querying for version with -v makes sense. /tmp is a painful contentions point that I'd like to discuss separately.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 5:
The tarball is good for the following reasons: 1. It bundles all required files we want to transfer at single transfer. 2. It contains correct file permissions (executable for example). 3. Content is like any other binary [or script] it should not be updated without upgrade of vdsm-bootstrap.
Using a directory so that we create a tarball on the fly without java gives no advantage, only runtime complexity compared to build time.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 6:
Split the patchset to several.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vds_bootstrap/setup-2 Line 177: subprocess.Popen(execfn).communicate() related to nothing:
the single most important change you can do here it to catch stdout/err and log them - currently unexpected exceptiions (eg ImportError) would go missing.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vds_bootstrap/setup-2 Line 177: subprocess.Popen(execfn).communicate() 1. This is the current behaviour... nothing was changed in this regard.
2. stderr is caught by engine and logged, so we ok in this regard.
3. stdout is expected to be valid at engine side and expected to flow as command runs, so if we override it we need to pipe it though.
I suggest to consider this in future separately from this change.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 7:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/9/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/9/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 7:
Update log default to use tempfile.gettempdir() as default.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 8:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/14/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 8:
Don't clean self directory, so that if someone runs script manually it won't destroy anything. Engine will cleanup the extract directory.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/14/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 9:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/15/
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 9:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/15/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 11: Verified
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 12:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/482/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 13: Verified
Now engine will create tarball on the fly.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 13:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/484/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 13: I would prefer that you didn't submit this
(3 inline comments)
only minor comments.
.................................................... File vds_bootstrap/setup Line 1: #!/usr/bin/python Line 2: # Line 3: # Copyright 2008-2012 Red Hat, Inc. history would have preferred that you started with importing the Engine script in one commit, and changing it in another.
never mind, not too important. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 6: # it under the terms of the GNU General Public License as published by Line 7: # the Free Software Foundation; either version 2 of the License, or
Line 36: vdsm_reg_conf_file = '/etc/vdsm-reg/vdsm-reg.conf' Line 37: Line 38: # Line 39: # bootstrap<->engine interface version Line 40: # 1 = <engine-3.1 =< ? did you not mean "<" ?
anyway, this versioning is going to be painful - upstream engine-3.1 has already been shipped with interface version = 1.... Let's not delve into this upstream/downstream discrepancy now. Line 41: # 2 = engine-3.1 Line 42: # Line 43: bootstrap_interface_version = 2 Line 44:
.................................................... File vdsm_reg/deployUtil.py.in Line 206: '/req_%s.conf' % random_num, Line 207: '/cert_%s.req' % random_num, Line 208: '/cert_%s.pem' % random_num, Line 209: '/CA_%s.pem' % random_num, Line 210: '/ovirt-id_rsa_%s' % random_num pardon my ignorance, but what does create this last file? is it guaranteed to be there always? Line 211: ): Line 212: os.unlink(_WORK_DIR + f) Line 213: except: Line 214: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 13: (3 inline comments)
.................................................... File vds_bootstrap/setup Line 1: #!/usr/bin/python Line 2: # Line 3: # Copyright 2008-2012 Red Hat, Inc. I thought about this, however, adding non working file as commit is also not too great. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 6: # it under the terms of the GNU General Public License as published by Line 7: # the Free Software Foundation; either version 2 of the License, or
Line 36: vdsm_reg_conf_file = '/etc/vdsm-reg/vdsm-reg.conf' Line 37: Line 38: # Line 39: # bootstrap<->engine interface version Line 40: # 1 = <engine-3.1 This is why I did not want to document this... but someone insisted. Line 41: # 2 = engine-3.1 Line 42: # Line 43: bootstrap_interface_version = 2 Line 44:
.................................................... File vdsm_reg/deployUtil.py.in Line 206: '/req_%s.conf' % random_num, Line 207: '/cert_%s.req' % random_num, Line 208: '/cert_%s.pem' % random_num, Line 209: '/CA_%s.pem' % random_num, Line 210: '/ovirt-id_rsa_%s' % random_num The engine, instead of script fetching this using HTTP. Line 211: ): Line 212: os.unlink(_WORK_DIR + f) Line 213: except: Line 214: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 14:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/500/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 14:
Minor changes for bootstrap interface handling.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 14: Verified
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vds_bootstrap/setup Line 36: vdsm_reg_conf_file = '/etc/vdsm-reg/vdsm-reg.conf' Line 37: Line 38: # Line 39: # bootstrap<->engine interface version Line 40: # 1 = <engine-3.1 Yep, someone is me. IMO, we should document it as it's as I already explained in my previous reviews.... Line 41: # 2 = engine-3.1 Line 42: # Line 43: bootstrap_interface_version = 2 Line 44:
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/504/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15:
Rebase.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: Verified
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: (1 inline comment)
and please do not get me into troubles with Douglas about documenting the interface versions...
.................................................... File vdsm_reg/deployUtil.py.in Line 210: '/req_%s.conf' % random_num, Line 211: '/cert_%s.req' % random_num, Line 212: '/cert_%s.pem' % random_num, Line 213: '/CA_%s.pem' % random_num, Line 214: '/ovirt-id_rsa_%s' % random_num pardon, but shouldn't this removal be limites to bootstrap_interface_version=2? Line 215: ): Line 216: os.unlink(_WORK_DIR + f) Line 217: except: Line 218: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 210: '/req_%s.conf' % random_num, Line 211: '/cert_%s.req' % random_num, Line 212: '/cert_%s.pem' % random_num, Line 213: '/CA_%s.pem' % random_num, Line 214: '/ovirt-id_rsa_%s' % random_num It should not exist after execute in any interface... why make code more complex? Line 215: ): Line 216: os.unlink(_WORK_DIR + f) Line 217: except: Line 218: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 210: '/req_%s.conf' % random_num, Line 211: '/cert_%s.req' % random_num, Line 212: '/cert_%s.pem' % random_num, Line 213: '/CA_%s.pem' % random_num, Line 214: '/ovirt-id_rsa_%s' % random_num well, it works "by chance", since this is the last file you try to remove, and since the nasty code here silently ignores all exceptions.
most of the ugliness here is not due to you, I know. you can keep your little addition to this pile - I'll wait anxiously for your pending overhaul. Line 215: ): Line 216: os.unlink(_WORK_DIR + f) Line 217: except: Line 218: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 15: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 210: '/req_%s.conf' % random_num, Line 211: '/cert_%s.req' % random_num, Line 212: '/cert_%s.pem' % random_num, Line 213: '/CA_%s.pem' % random_num, Line 214: '/ovirt-id_rsa_%s' % random_num Oh! you mean the unlink throws an exception?!?! If so I must fix this! Line 215: ): Line 216: os.unlink(_WORK_DIR + f) Line 217: except: Line 218: pass
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 16:
rebased to use the proper cleanup.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 16:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/508/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 17:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/510/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 17:
jenkins does not take patch 17... but reports that it does, strange.
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 17: Verified
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 17: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
Patch Set 17:
(even though this patch is still too big for my appetite)
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: send complete bootstrap from engine ......................................................................
bootstrap: send complete bootstrap from engine
CURRENT BEHAVIOR
vds_installer.py is part of ovirt-engine, upon bootstrap, the script is sent to the node using ssh.
Then vds_installer.py pulls vds-bootstrap* files using HTTP from engine.
The vds_installer.py and vds_bootstrap pulls ssh public key from engine using HTTP.
NEW BEHAVIOR
vds_installer.py was moved into the vdsm-bootstrap and renamed to setup.
vdsm-bootstrap repository was updated to create directory per bootstrap interface with 'setup' script.
ovirt-engine copies public key to node in similar way of firewall rules.
At bootstrap time, engine create tar archive from the bootstrap directory, cache it and pipe the archive into node in order to extract it and run the setup script.
No HTTP communication is needed.
No conflict with existing files.
BACKWARD COMPATIBILITY
Leave vds_bootstrap.py, vds_bootstrap_complete.py, deployUtil.py to be used by older engines. This should be removed in future.
SCRIPTS MODIFICATIONS
Set umask 0077 so only running user can access files.
Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M .gitignore M vds_bootstrap/Makefile.am A vds_bootstrap/setup M vds_bootstrap/vds_bootstrap.py M vdsm.spec.in M vdsm_reg/Makefile.am M vdsm_reg/deployUtil.py.in 7 files changed, 444 insertions(+), 28 deletions(-)
Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: Ofer Schreiber oschreib@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org