Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Added gluster support into vds bootstrap.
Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Signed-off-by: Timothy Asir tjeyasin@redhat.com --- M vds_bootstrap/vds_bootstrap.py 1 file changed, 35 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/3351/1 -- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 834: global GLUSTER_PACK the bootstrap code is an ugly pile of spaghetti, but that's not reason enough to modify a global CONSTANT within a function. Please find another way to pass the install_gluster boolean deeper into the stack.
Also please have new code with lines shorter than 80 chars, and with spaces after comas, and add yourself as an AUTHOR. Welcome, Timothy ;-)
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 834: global GLUSTER_PACK Done
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
however, we have a serious compatibility problem with the previous (-v/-g) patch. new bootstrap code must work with old Engine-3.0, which does not send the -v flag.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Haim Ateya has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 104: GLUSTER_PACK = ('vdsm-gluster', 'glusterfs-server', 'glusterfs-rdma', if its a gluster based host, which means its not going to manage any VMs, there is no need to require any of: libvirt, qemu-* and spice. any chance adding a condition there ?
Line 854: if installGlusterService: Do we only support RHEL6 based host? what about Fedora?
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 104: GLUSTER_PACK = ('vdsm-gluster', 'glusterfs-server', 'glusterfs-rdma', libvirt is required not only for VM-related stuff, also for network.
qemu (which requires stuff) could theoretically be required only by an vdsm-virt.rpm package - but such a package is not yet defined.
I would not mind if someone performs such a split, though. (ain't gonna be easy)
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Oved Ourfali has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 854: if installGlusterService: It supports fedora too.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 577: return self.rc Let's assume you get a log file from a customer, with some issue leading into this code area.
How can you trace the actual self.rc the function ended with, and the exit point?
Hits:
1. I try to keep a single exit point.
2. Debug logging may save you hours(!) of debugging and calls to the customer...
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Oved Ourfali has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 888: if not oDeploy.installGlusterPackages(): This should be if oDeploy.installGlusterPackages(), as the installGlusterPackages function currently returns 0 upon success.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 577: return self.rc _installPackage function does the logging of the success or failure status of the package installation.
Line 888: if not oDeploy.installGlusterPackages(): Done
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 3: Verified
Tested using new node and also using a node which has already installed vdsm and gluster packages.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 577: return self.rc Sorry, but I do not see any change here WRT my comments. Regardless of logging, why do you have so many exit points?
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
I do not mind short, readable functions with multiple exit points. But please, get Doron to ack this patch.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 4: No score
(1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 577: return self.rc Sorry, I will do the necessary changes to keep single exit point.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Doron Fediuck has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File AUTHORS Line 33: >>>>>>> Added gluster support into vds bootstrap. bad merge
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 5: No score
(1 inline comment)
.................................................... File AUTHORS Line 33: >>>>>>> Added gluster support into vds bootstrap. Sorry, I haven't noticed, I will fix it and send again.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Timothy Asir has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 6: Verified
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Patch Set 6: Looks good to me, approved
ok, if Doron is happy with this, it's fine by me.
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added gluster support into vds bootstrap. ......................................................................
Added gluster support into vds bootstrap.
Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Signed-off-by: Timothy Asir tjeyasin@redhat.com --- M AUTHORS M vds_bootstrap/vds_bootstrap.py 2 files changed, 53 insertions(+), 1 deletion(-)
Approvals: Timothy Asir: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3351 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Oved Ourfali oourfali@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Timothy Asir tjeyasin@redhat.com
vdsm-patches@lists.fedorahosted.org