Igor Lvovsky has posted comments on this change.
Change subject: Add partial vms list support to the regular 'list' query. ......................................................................
Patch Set 2: (3 inline comments)
.................................................... File vdsm/clientIF.py Line 692: d = vm.status() Line 693: if full: Line 694: return d Line 695: else: Line 696: return {'vmId': d['vmId'], 'status': d['status']} I can't understand what are you want here Line 697: return {'status': doneCode, Line 698: 'vmList': [reportedStatus(vm, full) for vm in self.vmContainer.values() Line 699: if not vms or vm.id in vms]} Line 700:
.................................................... File vdsm_cli/vdsClient.py Line 207: view = 'long' #Default view Line 208: vms = [] Line 209: Line 210: if args: Line 211: if args[0].startswith('vms:'): No, you still can use 'vms:' without 'table/long/ids' parameter Line 212: vms = _vmsParser(args[0]) Line 213: else: Line 214: view = args[0] Line 215: if len(args) > 1 and args[1].startswith('vms:'):
Line 222: #if not vms: Line 223: for res in self.s.getAllVmStats()['statsList']: Line 224: if not vms or res['vmId'] in vms: Line 225: allStats[ res['vmId'] ] = res Line 226: #else: Done Line 227: # for vm in vms: Line 228: # res = self.s.getVmStats(vm)['statsList'] Line 229: # allStats[vm] = res[0] Line 230:
-- To view, visit http://gerrit.usersys.redhat.com/956 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5051c42ca9e4ce706eff3cfec0de04cd76b2b95f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org