Xu He Jie has uploaded a new change for review.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
remove /var/log/core after vdsm uninstalled
remove /var/log/core after vdsm uninstalled
Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M build-aux/Makefile.subs M configure.ac M vdsm.spec.in M vdsm/Makefile.am 4 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/4027/1 -- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm.spec.in Line 593: %ghost %dir %attr(1777, root, root) %{_localstatedir}/log/core People do not like this directory in Fedora. It is intentionally limited to %{rhel}
-- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Xu He Jie has posted comments on this change.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm.spec.in Line 593: %ghost %dir %attr(1777, root, root) %{_localstatedir}/log/core So change another directory for fedora? what about '/var/log/vdsm/core' ?
-- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm.spec.in Line 593: %ghost %dir %attr(1777, root, root) %{_localstatedir}/log/core just make sure this dir is created only for rhel.
-- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm.spec.in Line 593: %ghost %dir %attr(1777, root, root) %{_localstatedir}/log/core you means keep this dir for rhel and remove the creation of this dir for fedora? or means jjust abandon this patchset?
-- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has abandoned this change.
Change subject: remove /var/log/core after vdsm uninstalled ......................................................................
Patch Set 1: Abandoned
Another change will be continue: http://gerrit.ovirt.org/#change,4348
-- To view, visit http://gerrit.ovirt.org/4027 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I89d58f5507de11f62e37dabef551c8b3d209aa22 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org