From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add ProcessLeakPlugin
......................................................................
tests: Add ProcessLeakPlugin
Add plugin for detecting leaked child processes.
Running with --with-process-leak-check will fail any test that leaked a
child process.
Example test that leak child processes:
def test_leak(self):
subprocess.Popen(["sleep", "60"])
Example run:
======================================================================
ERROR: test_leak (leak_test.TestLeak)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose/case.py", line 133, in run
self.runTest(result)
File "/usr/lib/python2.7/site-packages/nose/case.py", line 151, in
runTest
test(result)
AssertionError: Test leaked child processes:
[
{
"cmdline": [
"sleep",
"60"
],
"pid": 29386
}
]
To enable the plugin with make check:
make check NOSE_WITH_PROCESS_LEAK_CHECK=1
Change-Id: I451490d56f70ea8a6a685569d984495798e8b297
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/README
M tests/testValidation.py
M tests/testlib.py
3 files changed, 64 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/69324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I451490d56f70ea8a6a685569d984495798e8b297
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>