Francesco Romani has uploaded a new change for review.
Change subject: vm: remove guest agent channels tunables ......................................................................
vm: remove guest agent channels tunables
We had tunables to disable vm/ga channels creation from a long time, but it was just on debug purposes and these settings should never be used in production.
Moreover, we acttually rely on the channel being here (see RHBZ#1126887). Since it is now possible the achive the same results through hooks, is time to drop these tunables.
Change-Id: I4774441d7bd6dcdbb58e38886eb522851d4af37c Relates-To: https://bugzilla.redhat.com/1126887 Signed-off-by: Francesco Romani fromani@redhat.com --- M client/vdsClient.py M tests/vmTestsData.py M vdsm/virt/vm.py 3 files changed, 6 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/31245/1
diff --git a/client/vdsClient.py b/client/vdsClient.py index 2c09b28..ca82519 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1869,7 +1869,6 @@ # 'want to reserve with the machine' 'o acpiEnable : If present will remove the default ' '-no-acpi switch', - 'o qgaEnable : use qemu-ga as guest agent', 'o spiceSecureChannels : comma-separated list of ' 'spice channel that will be encrypted', 'o spiceMonitors : number of emulated screen heads', diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py index 02959fd..0990641 100644 --- a/tests/vmTestsData.py +++ b/tests/vmTestsData.py @@ -27,7 +27,6 @@ 'acpiEnable': 'true', 'cpuType': 'qemu64', 'smpCoresPerSocket': 1, 'smpThreadsPerCore': 1, 'smp': '1', 'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160', - 'vmchannel': 'true', 'qgaEnable': 'true', 'tabletEnable': False, 'displayNetwork': 'mydisp', 'custom': {}, 'guestNumaNodes': []}, @@ -95,7 +94,6 @@ 'acpiEnable': 'true', 'cpuType': 'qemu64', 'smpCoresPerSocket': 1, 'smpThreadsPerCore': 1, 'smp': '1', 'cpuPinning': {}, 'numaTune': {}, 'maxVCpus': '160', - 'vmchannel': 'true', 'qgaEnable': 'true', 'tabletEnable': False, 'displayNetwork': 'mydisp', 'custom': {}, 'guestNumaNodes': []}, diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 591616d..714b718 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2689,17 +2689,10 @@
domxml.appendNumaTune()
- if utils.tobool(self.conf.get('vmchannel', 'true')): - domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'), - _VMCHANNEL_DEVICE_NAME) - else: - self.log.warning('detected disabled vmchannel.' - ' This should be done ONLY for debug purposes' - ' and never in production environments') - if utils.tobool(self.conf.get('qgaEnable', 'true')): - domxml._appendAgentDevice( - self._qemuguestSocketFile.decode('utf-8'), - _QEMU_GA_DEVICE_NAME) + domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'), + _VMCHANNEL_DEVICE_NAME) + domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), + _QEMU_GA_DEVICE_NAME) domxml.appendInput()
if self.arch == caps.Architecture.PPC64: @@ -2841,8 +2834,7 @@ # So, run it after you have this info self._initVmStats() self.guestAgent = guestagent.GuestAgent( - self._guestSocketFile, self.cif.channelListener, self.log, - connect=utils.tobool(self.conf.get('vmchannel', 'true'))) + self._guestSocketFile, self.cif.channelListener, self.log)
self._guestCpuRunning = self._isDomainRunning() if self.lastStatus not in (vmstatus.MIGRATION_DESTINATION, @@ -4010,9 +4002,7 @@ snap.appendChild(_memorySnapshot(memoryVolPath)) else: snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY - - if utils.tobool(self.conf.get('qgaEnable', 'true')): - snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE + snapFlags |= libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
snapxml = snap.toprettyxml() self.log.debug(snapxml)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1420/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10745/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11687/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11530/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 2:
rebased.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1422/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10750/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11692/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11535/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1453/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10829/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11771/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11614/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1458/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10847/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11789/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11632/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1460/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10863/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11805/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11648/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 5: Verified+1
automation tests should be enough to cover verification of this change.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 5: Code-Review+1
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 5: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 5: Code-Review-1
sorry, manual rebase required due to http://gerrit.ovirt.org/26142
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1498/ : There was an infra issue, please contact infra@ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10963/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11905/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11748/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7: Verified+1
patch set 6, 7: rebased.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1499/ : There was an infra issue, please contact infra@ovirt.org
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10964/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11906/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11749/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7: Code-Review+1
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7:
But I'd like to be extra sure that Adam is fine with dropping this code.
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7: Code-Review+1
Adam Litke has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7: Code-Review+1
If my memory serves me well this code was added when IBM helped bring initial support for qemu-ga to oVirt. At that time we only had ovirt-guest-agent. At that time, it was requested that these channels be optional. Now that we fully support qemu-ga (and in fact require it) it makes complete sense to drop the tunable.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 7: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: remove guest agent channels tunables ......................................................................
vm: remove guest agent channels tunables
We had tunables to disable vm/ga channels creation from a long time, but it was just on debug purposes and these settings should never be used in production.
Moreover, we acttually rely on the channel being here (see RHBZ#1126887).
Since it is now possible the achive the same results through hooks, it is time to drop these tunables.
Change-Id: I4774441d7bd6dcdbb58e38886eb522851d4af37c Relates-To: https://bugzilla.redhat.com/1126887 Signed-off-by: Francesco Romani fromani@redhat.com Reviewed-on: http://gerrit.ovirt.org/31245 Reviewed-by: Vinzenz Feenstra vfeenstr@redhat.com Reviewed-by: Adam Litke alitke@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M client/vdsClient.py M tests/vmTestsData.py M vdsm/virt/vm.py 3 files changed, 9 insertions(+), 22 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5728/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/93/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3886/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1751/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 8:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17570/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 8:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17744/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: remove guest agent channels tunables ......................................................................
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17570/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17744/ : FAILURE
vdsm-patches@lists.fedorahosted.org