Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
BZ#848843 Enable vdsm hooks on fedora
Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/7266/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index 23afd6b..5224257 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -10,6 +10,10 @@ %global snlk_group @SNLKGROUP@ %global snlk_user @SNLKUSER@
+%if 0%{?fedora} +%global with_hooks 1 +%endif + # Required paths %global _polkitdir %{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/477/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/478/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Federico, any chance this can be done for koji builds alone? For me (and I suppose that for most people who build vdsm from source) it creates a lot of noise.
I understand the benefit of having the hook rpm built for a product release - but I find it unhelpful as the upstream default.
If you do build a Fedora build, maybe you can take http://gerrit.ovirt.org/7145 along with you...
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Federico Simoncelli has abandoned this change.
Change subject: BZ#848843 Enable vdsm hooks on fedora ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: If2532336b956cb01fd4090fccefd325c3cf2e571 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org