From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer: create python module and script wrapper
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/68808/8/lib/vdsm/supervdsmServer.py
File lib/vdsm/supervdsmServer.py:
Line 1: # Copyright 2016 Red Hat, Inc.
the code here is much much older, even though the file itself is new.
could you name the file consistently with pep8, eg supervdsm_server.py
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit
https://gerrit.ovirt.org/68808
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11f3bd8418be11235e95bd29fa62357742c85469
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes