Royce Lv has uploaded a new change for review.
Change subject: [WIP]normalize startup:change address owner ......................................................................
[WIP]normalize startup:change address owner
supervdsm server used to started by vdsm and it changed the address user to 'vdsm' to make it connectalbe. Now that supervdsm server is launched by superuser, changed the socket owner to be METADATA_USER
Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Signed-off-by: Royce Lvlvroyce@linux.vnet.ibm.com --- M vdsm/supervdsm.py M vdsm/supervdsmServer.py 2 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/10710/1
diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py index 44b01d9..81fb715 100644 --- a/vdsm/supervdsm.py +++ b/vdsm/supervdsm.py @@ -122,8 +122,7 @@ # permissions to read those files. superVdsmCmd = [constants.EXT_PYTHON, SUPERVDSM, self._authkey, str(os.getpid()), - self.pidfile, self.timestamp, self.address, - str(os.getuid())] + self.pidfile, self.timestamp, self.address]
misc.execCmd(superVdsmCmd, sync=False, sudo=True) sleep(2) diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer.py index f2279c2..180ea7a 100755 --- a/vdsm/supervdsmServer.py +++ b/vdsm/supervdsmServer.py @@ -48,7 +48,7 @@ from supervdsm import _SuperVdsmManager from storage.fileUtils import chown, resolveGid, resolveUid from storage.fileUtils import validateAccess as _validateAccess -from vdsm.constants import METADATA_GROUP, EXT_UDEVADM, \ +from vdsm.constants import METADATA_GROUP, METADATA_USER, EXT_UDEVADM, \ DISKIMAGE_USER, DISKIMAGE_GROUP, P_LIBVIRT_VMCHANNELS from storage.devicemapper import _removeMapping, _getPathsStatus import configNetwork @@ -349,7 +349,7 @@ sys.exit(errno.EPERM)
log.debug("Parsing cmd args") - authkey, parentPid, pidfile, timestamp, address, uid = sys.argv[1:] + authkey, parentPid, pidfile, timestamp, address = sys.argv[1:]
log.debug("Creating PID and TIMESTAMP files: %s, %s", pidfile, timestamp) @@ -383,7 +383,7 @@ servThread.start()
for f in (address, timestamp, pidfile): - chown(f, int(uid), METADATA_GROUP) + chown(f, METADATA_USER, METADATA_GROUP)
log.debug("Started serving super vdsm object")
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/622/ (1/2)
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/587/ (2/2)
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/622/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/587/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/627/ (1/2)
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/592/ (2/2)
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/627/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/592/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Royce Lv has abandoned this change.
Change subject: [WIP]normalize startup:change address owner ......................................................................
Patch Set 2: Abandoned
-- To view, visit http://gerrit.ovirt.org/10710 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: If5fb2506a63d7972d548c969bdf2fb7b9d4804b1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org