Mark Wu has uploaded a new change for review.
Change subject: Configure vdsm to use syslog ......................................................................
Configure vdsm to use syslog
By default, rsyslogd doesn't listening on UDP port 514. So change to use the unix domain socket '/dev/log' instead of udp socket. Then we we needn't modify rsyslog.conf to make rsyslogd accpet message from udp socket.
And rsyslogd puts a timestamp before the message automatically, so remove timestamp from the format 'sysform'
Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/logger.conf.in 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/4247/1 -- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Configure vdsm to use syslog ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Cool! Any idea if it works out-of-the-box in EL6, too?
minor comment within.
.................................................... File vdsm/logger.conf.in Line 72: format= VDSM %(name)s %(levelname)s %(message)s I FIND UPPERCASE AS TROUBLING TO THE EYE
let's call ourselves "vdsm" in log.
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Mark Wu has posted comments on this change.
Change subject: Configure vdsm to use syslog ......................................................................
Patch Set 2:
'/dev/log' is the default unix socket which rsyslogd listens on and the syslog function in glibc also submits message via writing to this socket. So it should also work on other distributions.
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Saggi Mizrahi has posted comments on this change.
Change subject: Configure vdsm to use syslog ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Configure vdsm to use syslog ......................................................................
Patch Set 2: (1 inline comment)
Come to think of it - wouldn't this fill up /var/log/message with vdsm INFO and ERRORs, hiding other stuff?
.................................................... File vdsm/logger.conf.in Line 72: format= vdsm %(name)s %(levelname)s %(message)s I see that it's commonplace to follow vdsm wiht a colon(:).
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Configure vdsm to use syslog ......................................................................
Patch Set 2: Verified; Looks good to me, approved
Answering myself: if this becomes too noisy, we can raise the logged level.
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Configure vdsm to use syslog ......................................................................
Configure vdsm to use syslog
By default, rsyslogd doesn't listening on UDP port 514. So change to use the unix domain socket '/dev/log' instead of udp socket. Then we we needn't modify rsyslog.conf to make rsyslogd accpet message from udp socket.
And rsyslogd puts a timestamp before the message automatically, so remove timestamp from the format 'sysform'
Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/logger.conf.in 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4247 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If386f780acedf5ff6d255cc4d4ece48ab2943ebc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org