From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: pylint: fix super() calls
......................................................................
pylint: fix super() calls
In normal cases, super() should not produce a proxy to a grandparent
class, but to an immediate parent class.
Change-Id: Ia31ab05ebec1fd83ca9bce4f0f064b9d943ac2ce
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/configurators/pyroute_two.py
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stomp.py
M tests/utils_test.py
4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/69344/1
diff --git a/lib/vdsm/network/configurators/pyroute_two.py
b/lib/vdsm/network/configurators/pyroute_two.py
index 8aece53..e76bd48 100644
--- a/lib/vdsm/network/configurators/pyroute_two.py
+++ b/lib/vdsm/network/configurators/pyroute_two.py
@@ -44,7 +44,7 @@
class PyrouteTwo(Iproute2):
def __init__(self, inRollback=False):
self.unifiedPersistence = True
- super(Iproute2, self).__init__(ConfigApplier(), inRollback)
+ super(PyrouteTwo, self).__init__(ConfigApplier(), inRollback)
self.runningConfig = RunningConfig()
def commit(self):
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 3a822ae..3485b8f 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -40,7 +40,7 @@
def __init__(self, code, msg):
self.code = code
self.message = msg
- super(RuntimeError, self).__init__(
+ super(JsonRpcError, self).__init__(
"[%d] %s" % (self.code, self.message)
)
diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py
index 392a63a..d8eee6d 100644
--- a/lib/yajsonrpc/stomp.py
+++ b/lib/yajsonrpc/stomp.py
@@ -82,7 +82,7 @@
class StompError(RuntimeError):
def __init__(self, frame, message):
self.frame = frame
- super(RuntimeError, self).__init__(message)
+ super(StompError, self).__init__(message)
class _HeartBeatFrame(object):
diff --git a/tests/utils_test.py b/tests/utils_test.py
index df6921f..c9a23bd 100644
--- a/tests/utils_test.py
+++ b/tests/utils_test.py
@@ -532,7 +532,7 @@
def __init__(self, *a, **kw):
self.record = None
- super(TestCaseBase, self).__init__(*a, **kw)
+ super(TestTraceback, self).__init__(*a, **kw)
def testDefaults(self):
@utils.traceback()
--
To view, visit
https://gerrit.ovirt.org/69344
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia31ab05ebec1fd83ca9bce4f0f064b9d943ac2ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>