Adam Litke has uploaded a new change for review.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
clusterLock: Acquire, release, and inquire volume leases
Although we have been creating volume leases on storage for awhile now, there have been no APIs to manage them. Add this support to the clusterLock implementations.
Change-Id: Icca901ccd27358767c023cd55b7a3823531d2a5a Signed-off-by: Adam Litke alitke@redhat.com --- M vdsm/storage/clusterlock.py M vdsm/storage/sd.py 2 files changed, 80 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/38622/1
diff --git a/vdsm/storage/clusterlock.py b/vdsm/storage/clusterlock.py index 51d2906..4077068 100644 --- a/vdsm/storage/clusterlock.py +++ b/vdsm/storage/clusterlock.py @@ -73,6 +73,10 @@ """Raised when the clusterlock class is not supporting inquire"""
+class ResourceLeasesNotSupportedError(Exception): + """Raised when the clusterlock class does not support resource leases""" + + class SafeLease(object): log = logging.getLogger("Storage.SafeLease")
@@ -145,7 +149,13 @@ raise se.AcquireLockFailure(self._sdUUID, rc, out, err) self.log.debug("Clustered lock acquired successfully")
+ def acquireResource(self, resource, lockDisk, shared=False): + raise ResourceLeasesNotSupportedError() + def inquire(self): + raise InquireNotSupportedError() + + def inquireResource(self, resource, lockDisk): raise InquireNotSupportedError()
def getLockUtilFullPath(self): @@ -165,6 +175,8 @@
self.log.debug("Cluster lock released successfully")
+ def releaseResource(self, resource, lockDisk): + raise ResourceLeasesNotSupportedError()
initSANLockLog = logging.getLogger("Storage.initSANLock")
@@ -286,13 +298,9 @@ # HOST_FAIL. return HOST_STATUS_FREE
- # The hostId parameter is maintained here only for compatibility with - # ClusterLock. We could consider to remove it in the future but keeping it - # for logging purpose is desirable. - def acquire(self, hostId): + def _acquire(self, resource, lockDisk, shared=False): with nested(self._lock, SANLock._sanlock_lock): - self.log.info("Acquiring cluster lock for domain %s (id: %s)", - self._sdUUID, hostId) + self.log.info("Acquiring resource %s, shared=%s", resource, shared)
while True: if SANLock._sanlock_fd is None: @@ -304,27 +312,42 @@ "Cannot register to sanlock", str(e))
try: - sanlock.acquire(self._sdUUID, SDM_LEASE_NAME, - self.getLockDisk(), - slkfd=SANLock._sanlock_fd) + sanlock.acquire(self._sdUUID, resource, lockDisk, + slkfd=SANLock._sanlock_fd, shared=shared) except sanlock.SanlockException as e: if e.errno != os.errno.EPIPE: raise se.AcquireLockFailure( self._sdUUID, e.errno, - "Cannot acquire cluster lock", str(e)) + "Cannot acquire sanlock resource", str(e)) SANLock._sanlock_fd = None continue
break
- self.log.debug("Cluster lock for domain %s successfully acquired " - "(id: %s)", self._sdUUID, hostId) + self.log.debug("Resource %s successfully acquired", resource) + + # The hostId parameter is maintained here only for compatibility with + # ClusterLock. We could consider to remove it in the future but keeping it + # for logging purpose is desirable. + def acquire(self, hostId): + self.log.info("Acquiring cluster lock for domain %s (id: %s)", + self._sdUUID, hostId) + self._acquire(SDM_LEASE_NAME, self.getLockDisk()) + self.log.debug("Cluster lock for domain %s successfully acquired " + "(id: %s)", self._sdUUID, hostId) + + def acquireResource(self, resource, lockDisk, shared=False): + self._acquire(resource, lockDisk, shared) + res, owners = self._inquire(resource, lockDisk) + self.log.debug("ALITKE: acquire: res:%s owners:%s", res, owners) + + def _inquire(self, resource, lockDisk): + res = sanlock.read_resource(*lockDisk[0]) + owners = sanlock.read_resource_owners(self._sdUUID, resource, lockDisk) + return res, owners
def inquire(self): - resource = sanlock.read_resource(self._leasesPath, SDM_LEASE_OFFSET) - owners = sanlock.read_resource_owners(self._sdUUID, SDM_LEASE_NAME, - self.getLockDisk()) - + resource, owners = self._inquire(SDM_LEASE_NAME, self.getLockDisk()) if len(owners) == 1: return resource.get("version"), owners[0].get("host_id") elif len(owners) > 1: @@ -334,19 +357,32 @@
return None, None
- def release(self): + def inquireResource(self, resource, lockDisk): + resource, owners = self._inquire(SDM_LEASE_NAME, self.getLockDisk()) + return (resource.get("version"), + [owner.get("host_id") for owner in owners]) + + def _release(self, resource, lockDisk): with self._lock: - self.log.info("Releasing cluster lock for domain %s", self._sdUUID) + self.log.info("Releasing resource %s", resource)
try: - sanlock.release(self._sdUUID, SDM_LEASE_NAME, - self.getLockDisk(), slkfd=SANLock._sanlock_fd) + sanlock.release(self._sdUUID, resource, lockDisk, + slkfd=SANLock._sanlock_fd) except sanlock.SanlockException as e: - raise se.ReleaseLockFailure(self._sdUUID, e) + raise se.ReleaseLockFailure(resource, e)
self._sanlockfd = None - self.log.debug("Cluster lock for domain %s successfully released", - self._sdUUID) + self.log.debug("Resource %s successfully released", resource) + + def release(self): + self.log.info("Releasing cluster lock for domain %s", self._sdUUID) + self._release(SDM_LEASE_NAME, self.getLockDisk()) + self.log.debug("Cluster lock for domain %s successfully released", + self._sdUUID) + + def releaseResource(self, resource, lockDisk): + self._release(resource, lockDisk)
class LocalLock(object): @@ -462,10 +498,16 @@ self.log.debug("Local lock for domain %s successfully acquired " "(id: %s)", self._sdUUID, hostId)
+ def acquireResource(self, resource, lockDisk, shared=False): + raise ResourceLeasesNotSupportedError() + def inquire(self): with self._globalLockMapSync: hostId, lockFile = self._getLease() return self.LVER, hostId if lockFile else None, None + + def inquireResource(self, resource, lockDisk): + raise InquireNotSupportedError()
def release(self): with self._globalLockMapSync: @@ -483,3 +525,6 @@
self.log.debug("Local lock for domain %s successfully released", self._sdUUID) + + def releaseResource(self, resource, lockDisk): + raise ResourceLeasesNotSupportedError() \ No newline at end of file diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py index a771abf..9e6f281 100644 --- a/vdsm/storage/sd.py +++ b/vdsm/storage/sd.py @@ -514,6 +514,18 @@ def inquireClusterLock(self): return self._clusterLock.inquire()
+ def acquireVolumeLease(self, imgUUID, volUUID, shared=False): + lockDisk = self.getVolumeLease(imgUUID, volUUID) + self._clusterLock.acquireResource(volUUID, [lockDisk], shared) + + def releaseVolumeLease(self, imgUUID, volUUID): + lockDisk = self.getVolumeLease(imgUUID, volUUID) + self._clusterLock.releaseResource(volUUID, [lockDisk]) + + def inquireVolumeLease(self, imgUUID, volUUID): + lockDisk = self.getVolumeLease(imgUUID, volUUID) + return self._clusterLock.inquireResource(volUUID, [lockDisk]) + def attach(self, spUUID): self.invalidateMetadata() pools = self.getPools()
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16556/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16727/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15757/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16563/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16734/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15764/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16728/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16900/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 4: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16816/ : UNSTABLE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16988/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 5: -Code-Review -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16849/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17021/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 6: -Verified
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16973/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 6:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17146/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16973/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17146/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 7: -Verified
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17052/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 7:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17226/
Adam Litke has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 7: Verified+1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17052/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17226/ : FAILURE
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8: -Verified
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17560/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17734/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17560/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17734/ : SUCCESS
Freddy Rolland has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8: Code-Review+1
Nir Soffer has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8:
(2 comments)
Mostly ok, but if we add new api, we need to rename to old api so both of them make sense. Since this not public api, there is no reason to keep the old names.
I think we should have:
- acquireClusterLock - releaseClusterLock - inquireClusterLock
- acquireResource - releaseResource - inquireResource
What do you think?
https://gerrit.ovirt.org/#/c/38622/8/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py:
Line 297: # timestamp, sanlock will return HOST_UNKNOWN and then HOST_LIVE or Line 298: # HOST_FAIL. Line 299: return HOST_STATUS_FREE Line 300: Line 301: def _acquire(self, resource, lockDisk, shared=False): Please move _private method to the end of the class, or to the end of the section using the private method. It should be easy to understand what is the public interface of the class by reading the code from top to bottom. Line 302: with nested(self._lock, SANLock._sanlock_lock): Line 303: self.log.info("Acquiring resource %s, shared=%s", resource, shared) Line 304: Line 305: while True:
Line 337: "(id: %s)", self._sdUUID, hostId) Line 338: Line 339: def acquireResource(self, resource, lockDisk, shared=False): Line 340: self._acquire(resource, lockDisk, shared) Line 341: res, owners = self._inquire(resource, lockDisk) Why do we need to call _inquire() here?
Add same logging as in acquire before and after the operation. Line 342: Line 343: def _inquire(self, resource, lockDisk): Line 344: res = sanlock.read_resource(*lockDisk[0]) Line 345: owners = sanlock.read_resource_owners(self._sdUUID, resource, lockDisk)
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 9: -Verified
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17907/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 9:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17736/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17907/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17736/ : SUCCESS
Adam Litke has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 8:
(2 comments)
I've made the requested changes (including renaming the acquire/inquire/release APIs for the clusterLock.
https://gerrit.ovirt.org/#/c/38622/8/vdsm/storage/clusterlock.py File vdsm/storage/clusterlock.py:
Line 297: # timestamp, sanlock will return HOST_UNKNOWN and then HOST_LIVE or Line 298: # HOST_FAIL. Line 299: return HOST_STATUS_FREE Line 300: Line 301: def _acquire(self, resource, lockDisk, shared=False):
Please move _private method to the end of the class, or to the end of the s
Done Line 302: with nested(self._lock, SANLock._sanlock_lock): Line 303: self.log.info("Acquiring resource %s, shared=%s", resource, shared) Line 304: Line 305: while True:
Line 337: "(id: %s)", self._sdUUID, hostId) Line 338: Line 339: def acquireResource(self, resource, lockDisk, shared=False): Line 340: self._acquire(resource, lockDisk, shared) Line 341: res, owners = self._inquire(resource, lockDisk)
Why do we need to call _inquire() here?
Done Line 342: Line 343: def _inquire(self, resource, lockDisk): Line 344: res = sanlock.read_resource(*lockDisk[0]) Line 345: owners = sanlock.read_resource_owners(self._sdUUID, resource, lockDisk)
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 10:
Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18307/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 10:
Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1537/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18307/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1537/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 10: Code-Review+1
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Jenkins CI RO has abandoned this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases ......................................................................
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
vdsm-patches@lists.fedorahosted.org