mooli tayer has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47
......................................................................
Patch Set 4:
(5 comments)
Sorry, submitted before replying.
http://gerrit.ovirt.org/#/c/33771/4/vdsm.spec.in
File vdsm.spec.in:
Line 80: BuildRequires: libselinux-python
Line 81: BuildRequires: libvirt-python
Line 82: BuildRequires: m2crypto
Line 83: BuildRequires: openssl
Line 84: BuildRequires: policycoreutils-python
we added also buildRequires for that.. i think we should add the
restrictio
Done, in "%if 0%{?rhel} == 6" bellow (l' 92)
Line 85: BuildRequires: psmisc
Line 86: BuildRequires: python-cpopen >= 1.3
Line 87: BuildRequires: python-inotify
Line 88: BuildRequires: python-ioprocess >= 0.12
Line 192: Requires: fence-agents
Line 193: Requires: kernel >= 2.6.32-279.9.1
Line 194: Requires: initscripts >= 9.03.31-2.el6_3.1
Line 195: Requires: policycoreutils >= 2.0.83-19.30
Line 196: Requires: policycoreutils-python > 2.0.83-19.47
I tested on a clean
centos machine.
Line 197: Requires: selinux-policy-targeted >= 3.7.19-195.el6_4.13
Line 198: Requires: lvm2 >= 2.02.100-5
Line 199: Requires: logrotate < 3.8.0
Line 200: %endif
Line 254: Requires: pyparted
Line 255:
Line 256: Requires(post): /usr/sbin/saslpasswd2
Line 257:
Line 258: %if 0%{?fedora} && 0%{?fedora} >= 21
yeah, not your fault, but the first 0%{?fedora} should be cleaned in
a futu
Done
Line 259: Requires(post): hostname
Line 260: %else
Line 261: Requires(post): /bin/hostname
Line 262: %endif
Line 260: %else
Line 261: Requires(post): /bin/hostname
Line 262: %endif
Line 263:
Line 264: %if 0%{?rhel} && 0%{?rhel} < 7
there's no need for the first '0%{?rhel}'. if rhel is
undefined, it evaluat
seems there is no need for this section anymore.
Line 265: Requires(post): policycoreutils-python > 2.0.83-19.47
Line 266: Requires(preun): policycoreutils-python > 2.0.83-19.47
Line 267: %else
Line 268: Requires(post): policycoreutils-python
Line 266: Requires(preun): policycoreutils-python > 2.0.83-19.47
Line 267: %else
Line 268: Requires(post): policycoreutils-python
Line 269: Requires(preun): policycoreutils-python
Line 270: %endif
why don't the Requires in lines 196 and 186 enough here?
apparently you are right. tested and they are enough.
I think we can remove 268 - 269 too
Line 271:
Line 272: %description
Line 273: The VDSM service is required by a Virtualization Manager to manage the
Line 274: Linux hosts. VDSM manages and monitors the host's storage, memory and
--
To view, visit
http://gerrit.ovirt.org/33771
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes