Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix code style for API. ......................................................................
Fix code style for API.
Apply the code style suggestions in: http://gerrit.ovirt.org/#/c/9993/1/vdsm/API.py
Change-Id: I5afe33338146506564d83983eb136c058fd25257 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm/API.py 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/10950/1
diff --git a/vdsm/API.py b/vdsm/API.py index 4462033..16bebb5 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -166,8 +166,8 @@ pickledMachineParams = pickle.load(f)
if type(pickledMachineParams) == dict: - self.log.debug('loaded pickledMachineParams ' - + str(pickledMachineParams)) + self.log.debug('loaded pickledMachineParams ' + + str(pickledMachineParams)) self.log.debug('former conf ' + str(vmParams)) vmParams.update(pickledMachineParams) finally: @@ -231,8 +231,8 @@ if vmParams.get('display') not in ('vnc', 'qxl', 'qxlnc'): return {'status': {'code': errCode['createErr'] ['status']['code'], - 'message': 'Unknown display type %s' - % vmParams.get('display')}} + 'message': 'Unknown display type %s' % + vmParams.get('display')}} if 'nicModel' not in vmParams: vmParams['nicModel'] = config.get('vars', 'nic_model') vmParams['displayIp'] = self._getNetworkIp(vmParams.get(
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix code style for API. ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/667/ (1/2)
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix code style for API. ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/702/ (2/2)
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix code style for API. ......................................................................
Patch Set 1: Verified
antoni@nx01 ~/code/vdsm> gitpydiff checking vdsm/API.py antoni@nx01 ~/code/vdsm>
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix code style for API. ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/667/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/702/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Fix code style for API. ......................................................................
Patch Set 1: Looks good to me, approved
pretty harmless.
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix code style for API. ......................................................................
Fix code style for API.
Apply the code style suggestions in: http://gerrit.ovirt.org/#/c/9993/1/vdsm/API.py
Change-Id: I5afe33338146506564d83983eb136c058fd25257 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm/API.py 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/10950 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I5afe33338146506564d83983eb136c058fd25257 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org