Bing Bu Cao has uploaded a new change for review.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Fixing pep8 in vdsm/define.py
Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Signed-off-by: Cao,Bing Bu mars@linux.vnet.ibm.com --- M Makefile.am M vdsm/define.py 2 files changed, 104 insertions(+), 36 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/4536/1 -- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Nice
.................................................... File vdsm/define.py Line 73: 'message': 'Guest agent non-responsive'}}, How about:
errCode = { 'noVM': {'status': {'code': 1, 'message': 'Virtual machine does not exist'}}, 'nfsErr': {'status': {'code': 3, 'message': 'Image repository access timeout'}}, 'exist': {'status': {'code': 4, 'message': 'Virtual machine already exists'}}, 'noVmType': {'status': {'code': 5, 'message': 'Unsupported VM type'}}, 'down': {'status': {'code': 6, 'message': 'Virtual machine is down'}}, 'copyerr': {'status': {'code': 7, 'message': 'Copy failed'}}, 'sparse': {'status': {'code': 8, 'message': 'sparse creation faild'}}, 'createErr': {'status': {'code': 9, 'message': 'Error creating the requested virtual machine'}}, 'noConPeer': {'status': {'code': 10, 'message': 'Could not connect to peer VDS'}}, 'MissParam': {'status': {'code': 11, 'message': 'Missing required parameter'}}, 'migrateErr': {'status': {'code': 12, 'message': 'Fatal error during migration'}}, 'imageErr': {'status': {'code': 13, 'message': 'Drive image file %s could not be found'}}, 'outOfMem': {'status': {'code': 14, 'message': 'Not enough free memory to create ' 'virtual machine'}}, 'unexpected': {'status': {'code': 16, 'message': 'Unexpected exception'}}, 'unsupFormat': {'status': {'code': 17, 'message': 'Unsupported image format'}}, 'ticketErr': {'status': {'code': 18, 'message': 'Error while setting spice ticket'}}, 'nonresp': {'status': {'code': 19, 'message': 'Guest agent non-responsive'}}, }
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/define.py Line 73: 'message': 'Guest agent non-responsive'}}, If more indentation,some line may out of the 79 column margin. example : "{'code': 13, 'message': 'Drive image file %s could not be found'}},"
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 2: (2 inline comments)
Mostly good, but I'd like someone else's opinion regarding changing the message before giving +1.
.................................................... File vdsm/define.py Line 44: 'message': 'Error creating the requested VM'}}, Not sure what to think of changing the message for line length in the code.
Line 61: 'Not enough free memory to create VM'}}, Same
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/define.py Line 44: 'message': 'Error creating the requested VM'}}, If everyone can understand the message changed the same as the original messge, I think it should be Okay.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 2: Verified
The changes pass vdsm test.
pydiff report:
$ pydiff define*.py 2 difference(s) first file: defineo.py second file: define.py
((28, 'Error creating the requested virtual machine'), (44, 'Error creating the requested VM'))
((33, 'Not enough free memory to create virtual machine'), (61, 'Not enough free memory to create VM'))
This means the only change in syntax logic is changing the string. If this change is acceptable, then the patch does not break anything.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/define.py Line 74: >>>>>>> f092812... Fixing pep8 in vdsm/define.py This looks like a left over from a merge conflict.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/define.py Line 74: >>>>>>> f092812... Fixing pep8 in vdsm/define.py Thanks for pointing this out. It should be removed.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Fixing pep8 in vdsm/define.py ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/define.py Line 74: >>>>>>> f092812... Fixing pep8 in vdsm/define.py Thanks,will remove the line.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: (1 inline comment)
pydiff report:
$ pydiff define*.py 3 difference(s) first file: defineo.py second file: define.py
((27, 'sparse creation failed'), (41, 'sparse creation faild'))
((28, 'Error creating the requested virtual machine'), (44, 'Error creating the requested VM'))
((33, 'Not enough free memory to create virtual machine'), (61, 'Not enough free memory to create VM'))
This means, while change "virtual machine" to "VM" may be acceptable, change "failed" to "faild" may be a misspelling.
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, faild or failed?
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: I would prefer that you didn't submit this
There is a misspelling in one of the strings as I mentioned in the last message. Now I feel I'd better give it -1.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, I think it will be OK after applied my another spell check patch. :)
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: No score
(1 inline comment)
The patch passes the vdsm tests.
pydiff report:
$ pydiff define*.py 3 difference(s) first file: defineo.py second file: define.py
((27, 'sparse creation failed'), (41, 'sparse creation faild'))
((28, 'Error creating the requested virtual machine'), (44, 'Error creating the requested VM'))
((33, 'Not enough free memory to create virtual machine'), (61, 'Not enough free memory to create VM'))
This means some strings are changed in the code. The first change is a spelling mistake, the other changes are acceptable.
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, If the mistake is in the original text, it will be OK to let it go and submit another spell check patch, but the original text is "failed" so the spelling mistake is introduced from this patch.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/define.py Line 27 You can see it was failed here. I don't know how you view it, but here the letter e is marked as changed.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: (1 inline comment)
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, Ah... I think it is a rebase problem. One patch series have been merged before. http://gerrit.ovirt.org/#/c/4303/
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 4: (1 inline comment)
Need rebase to get the spelling correction from another patch.
.................................................... File vdsm/define.py Line 27 The "failed" is originally "faild" here. And this patch keep it as is. Then there is another patch fix the spelling error. And this patch has not rebase to the latest master yet, so the spelling mistake is not introduced by the patch, we just need to rebase it.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 5: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Make vdsm/define.py PEP8 clean
Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Signed-off-by: Cao,Bing Bu mars@linux.vnet.ibm.com --- M Makefile.am M vdsm/define.py 2 files changed, 101 insertions(+), 33 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 6: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean ......................................................................
Patch Set 7: (1 inline comment)
There was a discussion about the 'failed' typo. Maybe we didn't make that clear enough with a -1, but it should be fixed.
.................................................... File vdsm/define.py Line 41: 'message': 'sparse creation faild'}}, Please fix this typo which has been re-introduced.
-- To view, visit http://gerrit.ovirt.org/4536 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org