Eduardo has uploaded a new change for review.
Change subject: BZ# - Fix virtio hotplug disk fail to a VM with IDE disks. ......................................................................
BZ# - Fix virtio hotplug disk fail to a VM with IDE disks.
Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/6970/1 -- To view, visit http://gerrit.ovirt.org/6970 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Haim Ateya has posted comments on this change.
Change subject: BZ# - Fix virtio hotplug disk fail to a VM with IDE disks. ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/6970 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ# - Fix virtio hotplug disk fail to a VM with IDE disks. ......................................................................
Patch Set 1: (1 inline comment)
it smells that you should maintain the list of used nics.
.................................................... File vdsm/vm.py Line 530: if not self._usedIndices.has_key(drv['iface']): pep8 dislikes has_key(). use "not in" instead.
-- To view, visit http://gerrit.ovirt.org/6970 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks. ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6970 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks. ......................................................................
BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks.
Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved oVirt Jenkins CI Server: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/6970 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org