Dan Kenigsberg has posted comments on this change.
Change subject: change misc.retry to make it more general
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I like this generalization of misc.retry(), but I'm asking for more ;-)
....................................................
File vdsm/storage/misc.py
Line 737: def retry(func, argList=[], expectedException=Exception, tries=None,
it is usually called just "args".
consider adding kwargs, too, to make it even more general.
--
To view, visit
http://gerrit.ovirt.org/4032
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>