From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by VDSM
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/79495/4//COMMIT_MSG
Commit Message:
PS4, Line 10: but default route
So if the management is not really with the default route, then we
loose th
ack for a compulsory argument. When it is not supplied by the user, the
error message prints the default route network as a suggestion.
https://gerrit.ovirt.org/#/c/79495/4/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
PS4, Line 104: net_api.network_caps()
Why can't you use just the caps? This will reduce the need to
depend on the
we'd like to keep the management network, but remove its bridge in
case it exists; if we do not use KernelConfig, we'd have to reimplement some of it
here.
--
To view, visit
https://gerrit.ovirt.org/79495
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes