ShaoHe Feng has uploaded a new change for review.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
fix two parameters of VmParameters in vdsmapi schema
from the comments of VmParameters, the two parameters are #optional
Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/9112/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index d210c7d..6fa45de 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2382,8 +2382,8 @@ 'data': {'acpiEnable': 'bool', '*custom': 'StringMap', '*devices': ['VmDevice'], 'display': 'VmDisplayType', 'kvmEnable': 'bool', 'memSize': 'uint', - 'nice': 'int', 'smp': 'uint', 'smpCoresPerSocket': 'uint', - 'smpThreadsPerCore': 'uint', 'timeOffset': 'uint', + 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', + '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1:
What's the relationship of http://gerrit.ovirt.org/#/c/9112/ and http://gerrit.ovirt.org/#/c/9113/?
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1:
How about putting them under the topic schema_fix (http://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:sch...).
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1:
This one fixes Adam's patch. http://gerrit.ovirt.org/#/c/7839/8/vdsm_api/vdsmapi-schema.json when I review Adam's patch, it was already merged. So I have to submit a new patch to fix it. have added Adam to reviewer list to check it.
when I run process-schema.py to generate an html, it cause an error. "ValueError: symbol: Image.cloneStructure not found" so I debug it and submit another patch.
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1: I would prefer that you didn't submit this
This is already fixed now, right?
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
ShaoHe Feng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1:
I have update my git repository. This is not fixed yet. there are two places that define "smpCoresPerSocket" and "smpThreadsPerCore". only one place is right to set optional.
I found this bug when I review your patch after is was merged, sorry I did not notice it was merged at that time. http://gerrit.ovirt.org/7839
There are many schema syntax errors on the gerrit. IMO it is impossible to catch these errors by our eyes.
So I submit a patch to validate the schema at build time , and it was merged . http://gerrit.ovirt.org/#/c/9433/
But the optional error can not be caught at build time. IMO the the process-schema.py should be improved to catch this kind of error.
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/493/ (1/2)
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/528/ (2/2)
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/493/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/528/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
ShaoHe Feng has posted comments on this change.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
fix two parameters of VmParameters in vdsmapi schema
from the comments of VmParameters, the two parameters are #optional
Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Signed-off-by: ShaoHe Feng shaohef@linux.vnet.ibm.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: ShaoHe Feng: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org