Dan Kenigsberg has posted comments on this change.
Change subject: Add general Device class
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 803: class LibvirtNetwork(vm.Device):
NetInterface is more exact
....................................................
File vdsm/vm.py
Line 61: class Drive(Device):
I agree that maintaining this class here is not fruitful; you can do just like with
LibvitVm.Network
--
To view, visit
http://gerrit.ovirt.org/792
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>