Dan Kenigsberg has posted comments on this change.
Change subject: Add a test case for _handleMessage()
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File tests/guestIFTests.py
Line 16: # Foundation, Inc., 51 Franklin Street, :Fifth Floor, Boston, MA
intentional colon?
Line 62: [{'hw': '00:21:cc:68:d7:38', 'name':
'eth0', 'inet':
misleading indentation.
maybe add a newline to separate inputs?
Line 74: for i in range(len(testCaseBuilders))]
I do not understand why you need the builders' complexity, instead of writing down a
list of testCases in code...
I find something like
tests = [builder(inp) for builder, inp in zip(testCaseBuilders, inputs)]
more pythonic and clearer.
--
To view, visit
http://gerrit.ovirt.org/5819
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec467cdef122999a28b3e47cd24e25192df10c21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>