Igor Lvovsky has uploaded a new change for review.
Change subject: Do not validate image during the move operation ......................................................................
Do not validate image during the move operation
Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa --- M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sp.py 3 files changed, 0 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/2756/1 -- To view, visit http://gerrit.ovirt.org/2756 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Do not validate image during the move operation ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Finally getting rid of this function! Next is domain and pool validate After that get rid of image.move entirely !!! (but all this is not for this patch)
.................................................... File vdsm/storage/hsm.py Line 1297: self.validateSdUUID(dstDomUUID) What about validating that the image is not a template? We'd like to deprecate this command anyway, let's limit it as much as we can in the meantime.
Line 1327: images[imgUUID.strip()] = misc.parseBool(pZero) same as above
-- To view, visit http://gerrit.ovirt.org/2756 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Igor Lvovsky has abandoned this change.
Change subject: Do not validate image during the move operation ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/2756 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
vdsm-patches@lists.fedorahosted.org