Dan Kenigsberg has uploaded a new change for review.
Change subject: Add a basic xmlrpc functional test ......................................................................
Add a basic xmlrpc functional test
Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/functional/Makefile.am A tests/functional/xmlrpcTests.py 2 files changed, 71 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/5788/1 -- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Royce Lv has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 1: Verified
(2 inline comments)
.................................................... File tests/functional/xmlrpcTests.py Line 45: self.assertIn(r['statsList'][0]['status'], ('Up', 'Powering up')) I remember the "Running" status is also a valid up status for vm with guest agent
Line 59: VMID = '66666666-ffff-4444-bbbb-333333333333' Can I advice using str(uuid.uuid4())? ;)
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 1: (2 inline comments)
.................................................... File tests/functional/xmlrpcTests.py Line 45: self.assertIn(r['statsList'][0]['status'], ('Up', 'Powering up')) Done
Line 59: VMID = '66666666-ffff-4444-bbbb-333333333333' I actually prefer to reduce the amount of randomness in tests.
I'd like to reconsider once we have multiple concurrent VMs.
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Royce Lv has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2: I would prefer that you didn't submit this
I got a libvirt(libvirt-0.9.11.4-3.fc17.x86_64) error when verifying this patch, may need to take deeper look in this: Thread-39::DEBUG::2012-07-02 21:15:03,673::BindingXMLRPC::879::vds::(wrapper) return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList': [{'status': 'WaitForLaunch', 'hash': '0', 'acpiEnable': 'true', 'pid': '0', 'displayIp': '0', 'displayPort': '-1', 'displaySecurePort': '-1', 'timeOffset': '0', 'kvmEnable': 'true', 'network': {}, 'vmId': '66666666-ffff-4444-bbbb-333333333333', 'displayType': 'vnc', 'disks': {}, 'monitorResponse': '0', 'elapsedTime': '0', 'vmType': 'kvm', 'clientIp': '', 'nice': ''}]} Thread-37::DEBUG::2012-07-02 21:15:03,942::vm::580::vm.Vm::(_startUnderlyingVm) vmId=`66666666-ffff-4444-bbbb-333333333333`::_ongoingCreations released Thread-37::ERROR::2012-07-02 21:15:03,942::vm::604::vm.Vm::(_startUnderlyingVm) vmId=`66666666-ffff-4444-bbbb-333333333333`::The vm start process failed Traceback (most recent call last): File "/usr/share/vdsm/vm.py", line 570, in _startUnderlyingVm self._run() File "/usr/share/vdsm/libvirtvm.py", line 1365, in _run self._connection.createXML(domxml, flags), File "/usr/lib64/python2.7/site-packages/vdsm/libvirtconnection.py", line 82, in wrapper ret = f(*args, **kwargs) File "/usr/lib64/python2.7/site-packages/libvirt.py", line 2420, in createXML if ret is None:raise libvirtError('virDomainCreateXML() failed', conn=self) libvirtError: internal error Process exited while reading console log output: char device redirected to /dev/pts/4 getaddrinfo(0,5900): Name or service not known
Thread-37::DEBUG::2012-07-02 21:15:03,947::vm::920::vm.Vm::(setDownStatus) vmId=`66666666-ffff-4444-bbbb-333333333333`::Changed state to Down: internal error Process exited while reading console log output: char device redirected to /dev/pts/4 getaddrinfo(0,5900): Name or service not known
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Trying to reproduce Royce's issue, I've found another one...
.................................................... File tests/functional/xmlrpcTests.py Line 47: self.assertIn(r['statsList'][0]['status'], self.UPSTATES) assertIn is missing from python 2.6's unittest.
so I will have to re-implement it.
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/184/
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/184/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File tests/functional/xmlrpcTests.py Line 32: Line 33: class XMLRPCTest(TestCaseBase): Line 34: UPSTATES = set(('Up', 'Powering up', 'Running')) Line 35: Line 36: def __init__(self, *args, **kwargs): Could these initialization be moved to "def setUp(self)"? In http://nose.readthedocs.org/en/latest/writing_tests.html "Test classes" section, it says, "Like unittest.TestCase subclasses, other test classes can define setUp and tearDown methods that will be run before and after each test method." Line 37: TestCaseBase.__init__(self, *args, **kwargs) Line 38: self.s = vdscli.connect() Line 39: Line 40: def testGetCaps(self):
Line 66: try: Line 67: self.retryAssertVmUp(VMID, 20) Line 68: finally: Line 69: # FIXME: if the server dies now, we end up with a leaked VM. Line 70: r = self.s.destroy(VMID) If vdsm fails and we are able to connect to libvirt, we can ask libvirt to destroy domain "foo".
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 2: Verified
run through autobuild. install the rpms and start the service. run the test, it succeeds. stop the service, run the test, it reports failure.
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/736/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Add a basic xmlrpc functional test ......................................................................
Patch Set 3: Looks good to me, approved
Thanks, Zhou!
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add a basic xmlrpc functional test ......................................................................
Add a basic xmlrpc functional test
Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/functional/Makefile.am A tests/functional/xmlrpcTests.py 2 files changed, 84 insertions(+), 1 deletion(-)
Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5788 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I6ab2ac67717339cac697df4b507e65cf0a4a8f19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org