From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding grub2-tool requirement which host-deploy requires
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:
Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8:
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
I trust Bronheim that he picked the best tool for the job and
considered be
So in this case I tend to agree that we need a maintainer to stop such
changes as I did here. I agree that someone might remove it in the future, so its really
not the right way to handle such requirements from the system.. I'll check if I can
install grub2-tool as part of the host-deploy process. meanwhile, i abandon the change.
Line 12:
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
--
To view, visit
https://gerrit.ovirt.org/69462
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes