Federico Simoncelli has posted comments on this change.
Change subject: Support fake_kvm in vds_bootstrap
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 612: if config.getboolean('vars', 'fake_kvm_support'):
since we do NOT plan to ever flip the default value of
fake_kvm_support
Dan, agreed... that is obvious. But beware, the intent of:
config.getboolean('vars', 'fake_kvm_support')
is to maintain the value present in vdsm.conf if it's defined (which overrides the
default). Anyway everything is neutralized by line 602 (!).
--
To view, visit
http://gerrit.ovirt.org/5611
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If384e70ae9c43edf36cc2575166b472fbad78c41
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>