From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/79664/3/lib/vdsm/m2cutils.py File lib/vdsm/m2cutils.py:
Line 331: excludes = 0 Line 332: Line 333: for no_protocol in config.get('vars', 'ssl_excludes').split(','): Line 334: if no_protocol != '': Line 335: protocol = 'SSL_' + no_protocol.strip()
SSL_OP_NO_TLSv1_1 is not supported. Only two values are supported as specif
didn't we say that we'll just support both ..? you agreed. just add the SSL_ prefix if it was not provided.
But I don't mind to restrict it. Line 336: if protocol == 'SSL_OP_NO_TLSv1_1': Line 337: # not all m2crypto provide this constant Line 338: excludes |= 268435456 Line 339: else:
vdsm-patches@lists.fedorahosted.org