Edward Haas has posted comments on this change.
Change subject: net: early IP+link setup
......................................................................
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/60371/12/lib/vdsm/tool/restore_nets_init.py
File lib/vdsm/tool/restore_nets_init.py:
Could we move this module under network/ ?
Line 1: # Copyright 2016 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 50: if persistence != 'unified':
Line 51: logging.info('Skipping: Unified persistence is not used.')
Line 52: return
Line 53:
Line 54: if _nets_already_restored(_NETS_RESTORED_MARK):
This bothers me a bit.
We are not comparing kernel vs config here and on reset we depend on the marking.
Hope we are not missing anything here.
Line 55: logging.info('Skipping: Networks were already restored.')
Line 56: return
Line 57:
Line 58: logging.info('Starting initial network setup.')
--
To view, visit
https://gerrit.ovirt.org/60371
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0555a61c9709be54bfb2587e3020d3046db10ec6
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes