Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#743272 - dirList IS and WAS dirList. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
Putting the task id in set() is not really required... I don't expect any duplicates there. But it is what the former code did, so ok.
-- To view, visit http://gerrit.usersys.redhat.com/993 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0fbcdb4076a5c16fd74754350464f382636ff419 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo Warszawski ewarszaw@redhat.com Gerrit-Reviewer: Yotam Oron yoron@redhat.com
vdsm-patches@lists.fedorahosted.org