From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: use native strings with libnl
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/77716/4//COMMIT_MSG
Commit Message:
Line 4: Commit: Petr Horáček <phoracek(a)redhat.com>
Line 5: CommitDate: 2017-06-02 23:17:44 +0200
Line 6:
Line 7: network: use native strings with libnl
Line 8:
I miss the motivation for this.
I don't like this leniency; I'd expect the caller to worry about sending unicode
in python2 and string in python2.
Simplifying our life (as the sole user of libnl.py) is a good reason, but I'd like to
understand where exactly this helps.
Line 9: Change-Id: I21dec9beeb6a70fc16005a85669d1826b785bf9b
--
To view, visit
https://gerrit.ovirt.org/77716
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21dec9beeb6a70fc16005a85669d1826b785bf9b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes