From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: network: decode command output to native string ......................................................................
Patch Set 25: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/77724/25/lib/vdsm/network/cmd.py File lib/vdsm/network/cmd.py:
PS25, Line 62: 'utf-8' we should remember (and note in exec_sync doc string) that a generic application may output non-utf8 output, e.g.
python -c "print('\xe3')"
yet we assume that all of our command lines behave. If we take this cowardly course, let us add an xfail test, as a TODO to our future selves.
vdsm-patches@lists.fedorahosted.org