Mark Wu has uploaded a new change for review.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Enable fake_kvm_support on hosts without hardware VT support automatically
Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm.spec.in 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/6062/1 -- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/187/
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/187/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: I would prefer that you didn't submit this
I'd rather have the full picture of this use case first - how do we make sure users with physical hosts who just don't have this enabled by bios and should fail on adding the host rather than have it faked?
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Good point Itamar, thanks for that catch! Moving to -1, Mark can you please share the use case?
Thanks!
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Deepak C Shetty has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
Mark, Found some google answers on "how to find if VT is disabled in BIOS".. not sure if it works all the time... but thought it would be good to check with experts here ..
1) you don't have a "KVM: disabled by BIOS" line in the output of dmesg -- but what if dmesg was cleared or rolled over ?
2) Look at http://askubuntu.com/questions/103965/how-to-determine-if-cpu-vt-extensions-...
Hope it helps
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
vdsm bootstrap already has code for this detection, please look at it first. though not sure if it would distinguish between disabled by bios and nested virtualization cases
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
Itamar, 1. My understanding is that the bootstrap detection you mentioned is a fix for fake_kvm_support. Without that fix, engine would refuse to add the virtual vdsm host even fake_kvm_support is enabled. And the purpose of this patch is enable the option fake_kvm_support on non VT host automatically. That could be helpful for test.
2. /proc/cpuinfo always report the cpu flag (vmx) if the cpu has the capability even if virtualization support is disabled in bios. So I think it's fine to determine if the host has virt support by the cpu flag.
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: No score
iirc, vdsm has code to detect bios enablement, regardless vmx flag. but if vmx flag is always visible even if VT is disabled in bios (and same check has been done for AMD for svm flag), then i think this patch is ok. but please verify both intel and amd with a *cold* boot of the system (bios change for VT does not take effect on a warm reboot).
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Hi Itamar, I have tested in both (AMD and Intel) and they always report the virt flags (even if it's disabled in the BIOS + cold reboot) Thanks for the review!
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
Douglas, Thanks for verifying it on both Intel and AMD platform.
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm.spec.in Line 527: Line 528: %post hook-faqemu Line 529: cat /proc/cpuinfo | grep -q "vmx | svm" Line 530: vt_supported=$? Line 531: if [ $vt_supported -ne 0 ]; then frankly, I do not like editing our own configuration scripts... Would you agree to limit this editing to cases where a human did not have something else in vdsm.conf ?
I mean - if someone explicitly wrote
fake_kvm_support=False
we should not override that. Line 532: /usr/share/vdsm/set-conf-item /etc/vdsm/vdsm.conf vars fake_kvm_support true Line 533: fi Line 534: Line 535: %files
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm.spec.in Line 527: Line 528: %post hook-faqemu Line 529: cat /proc/cpuinfo | grep -q "vmx | svm" Line 530: vt_supported=$? Line 531: if [ $vt_supported -ne 0 ]; then Sorry, I can't see why people disable fake_kvm_support explicitly on a host withou vt capability. I assume that people want to use fake kvm if he installs the package. Even if he installs it unintentionally, the override should be safe. Please let me know any case I am not taking into consideration. Thanks! Line 532: /usr/share/vdsm/set-conf-item /etc/vdsm/vdsm.conf vars fake_kvm_support true Line 533: fi Line 534: Line 535: %files
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Itamar Heim has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
my concern is actually the reverse - this removes the need of users to enable fake support. so we may get people running this in VMs or something like that. if we do this, i think engine should be aware of it. i.e., report also a fakeqemu cpu flag by vdsm to make it visible (and probably have engine flag it somehow)
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
vdsm uses 'Intel(Fake) CPU' as cpuModel to report to engine, so I think engine could tell it according to this information if it wants.
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1:
It seems we needn't spend more time on fake_kvm_support, because we nested kvm support for test now. I am going to abandon it if no other ideas.
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has abandoned this change.
Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically ......................................................................
Patch Set 1: Abandoned
-- To view, visit http://gerrit.ovirt.org/6062 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org