From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Enable metrics by default ......................................................................
Enable metrics by default
Same patch as https://gerrit.ovirt.org/#/c/66229, adding the missing requirement.
Change-Id: I12201f3e2a6b4c8f0a5ea7efbc422821f362f7d1 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M lib/vdsm/config.py.in M vdsm.spec.in 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/66257/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in index 47184ab..d606da2 100644 --- a/lib/vdsm/config.py.in +++ b/lib/vdsm/config.py.in @@ -452,8 +452,8 @@
# Section: [metrics] ('metrics', [ - ('enabled', 'false', - 'Enable metrics collection (default false)'), + ('enabled', 'true', + 'Enable metrics collection (default true)'),
('collector_address', 'localhost', 'Metrics collector address (default localhost)'), diff --git a/vdsm.spec.in b/vdsm.spec.in index 7d5154a..eb5cd22 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -96,6 +96,7 @@ Requires: python-ioprocess >= 0.16.1-1 Requires: python-pthreading >= 0.1.3-3 Requires: python-six >= 1.9.0 +Requires: python-statsd Requires: python-requests Requires: rpm-python Requires: nfs-utils
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 1:
please wait with that a bit more, I want to verify also upgrade
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 2: Verified+1
please re-review. added the missing requirement and verified over rhel and fedora. it works with no effect on vdsm. I wonder if to add debug log print to see what is sent and maybe require also collectd. but its for separate patch and separate discussion
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/66257/2/vdsm.spec.in File vdsm.spec.in:
Line 95: Requires: python-cpopen >= 1.4 Line 96: Requires: python-ioprocess >= 0.16.1-1 Line 97: Requires: python-pthreading >= 0.1.3-3 Line 98: Requires: python-six >= 1.9.0 Line 99: Requires: python-statsd
Please also add this to automation/check-*.packages.*
only for check-merged its important. but why would it fail? no tests import it Line 100: Requires: python-requests Line 101: Requires: rpm-python Line 102: Requires: nfs-utils Line 103: Requires: m2crypto
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 3:
this is odd and annoying. basically as far as I see we don't have any change in any new package that we start to be depend on. any introduction of new requirement now requires all this places that you mention. isn't that lovely? :) almost like adding new file to our project.. why not to have one list for all those places some how if you already added this check_import officer?
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 5: Verified+1
im not sure after your mail if we need it also in build-artifacts packages
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 6:
seems like they renamed it recently in epel. ""python2-statsd noarch 3.2.1-2.el7 @epel """
I'll change to require this one
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 8: Verified+1
simplified the issue with https://gerrit.ovirt.org/#/c/67004
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enable metrics by default ......................................................................
Patch Set 9:
ready too.
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Enable metrics by default ......................................................................
Enable metrics by default
To avoid restart of vdsm service after first engine deploy to enable metrics we set the metrics to enabled by default.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1392784 Change-Id: I12201f3e2a6b4c8f0a5ea7efbc422821f362f7d1 Signed-off-by: Yaniv Bronhaim ybronhei@redhat.com --- M lib/vdsm/config.py.in 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Piotr Kliczewski: Looks good to me, approved Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve
vdsm-patches@lists.fedorahosted.org