Xu He Jie has uploaded a new change for review.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
remove INSTALL from git and add it to .gitignore
autoreconf -if always update INSTALL file. so remove it from git.
Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M .gitignore D INSTALL 2 files changed, 1 insertion(+), 365 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/5945/1 -- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Royce Lv has posted comments on this change.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
The INSTALL's annoying, some of my patch submitted with it mistakenly:(
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
Patch Set 2:
v2: sort .gitignore file and update comment
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Mark Wu has posted comments on this change.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
remove INSTALL from git and add it to .gitignore
After running autogen.sh, I found the file "INSTALL" was modified. 'git diff' reports the following change:
-Copyright (C) 1994, 1995, 1996, 1999, 2000, 2001, 2002, 2004, 2005, -2006, 2007, 2008, 2009 Free Software Foundation, Inc. +Copyright (C) 1994-1996, 1999-2002, 2004-2011 Free Software Foundation, +Inc.
...
+ HP-UX `make' updates targets which have the same time stamps as +their prerequisites, which makes it generally unusable when shipped +generated files such as `configure' are involved. Use GNU `make' +instead.
It's caused by the update in autoconf. Just adding it to gitigore does't help because it's already tracked. In my understanding, we needn't maintain 'INSTALL' in git repository, so remove it.
Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M .gitignore D INSTALL 2 files changed, 15 insertions(+), 379 deletions(-)
Approvals: Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: remove INSTALL from git and add it to .gitignore ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/5945 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I82687846afc8e86738eb5800623d1f4eac423487 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org