Xu He Jie has uploaded a new change for review.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Move the creation of /data/updates out of init script
* move the creation of /data/updates to vdsm_reg/vdsm-reg-setup.in * remove /data/updates after vdsm rpm uninstalled
Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M build-aux/Makefile.subs M configure.ac M vdsm.spec.in M vdsm/vdsmd.init.in M vdsm_reg/Makefile.am R vdsm_reg/config.py.in M vdsm_reg/vdsm-reg-setup.in M vdsm_reg/vdsm-reg.conf.in M vdsm_reg/vdsm-upgrade 9 files changed, 28 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/4025/1 -- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
But I do like the idea, please push it through.
.................................................... Commit Message Line 10: * remove /data/updates after vdsm rpm uninstalled The most interesting thing to put in a commit message is the WHY. The motivation is not self-evident, even though I can think of two:
1. vdsmd.init is too complex
2. /data/updates is relevant only to vdsm-reg and ovirt-node, not vdsm proper.
.................................................... File vdsm_reg/vdsm-reg-setup.in Line 234: upgradeDir = os.path.dirname(config.get('vars', trailing redspace
Line 237: if not os.path.exists(upgradeDir): this code was in a separate (bash) function. the containing run() function is too long as it is. so let's keep in its own (python) function.
.................................................... File vdsm_reg/vdsm-upgrade Line 17: from config import config this change of how "config" is read, is not really related, let's review it separately, in its own patch.
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Xu He Jie has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 1:
OK, I will send patchset2 later. Thanks for your review!
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... Commit Message Line 10: * remove /data/updates after vdsm rpm uninstalled you forgot to update to commit message with the reasons why this change is good.
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Move the creation of /data/updates out of init script
Move the creation of /data/updates out of init script, make init script more simple.
* move the creation of /data/updates to vdsm_reg/vdsm-reg-setup.in vdsm-reg-setup can create '/data/updates' after host register to engine.
* remove /data/updates after vdsm rpm uninstalled
Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Signed-off-by: Xu He Jie xuhj@linux.vnet.ibm.com --- M build-aux/Makefile.subs M configure.ac M vdsm.spec.in M vdsm/vdsmd.init.in M vdsm_reg/Makefile.am R vdsm_reg/config.py.in M vdsm_reg/vdsm-reg-setup.in M vdsm_reg/vdsm-reg.conf.in 8 files changed, 24 insertions(+), 14 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Xu He Jie: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move the creation of /data/updates out of init script ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm_reg/config.py.in Line 37: config.set('vars', 'vdsm_dir', '/usr/share/vdsm') /usr/share/vdsm could have been replaced with @vdsmdir@
-- To view, visit http://gerrit.ovirt.org/4025 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9f8617fdaca3110791a93bb3a5906f30ace2499d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org